Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: remove old bootstrap assets #232

Merged

Conversation

abhinavdahiya
Copy link
Contributor

openshift/installer#879 merged that switches to the new bootstrap manifests. So we can drop the old ones now.

/cc @ashcrow

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2018
@abhinavdahiya abhinavdahiya changed the title bootstrap: remove old boostrap assets bootstrap: remove old bootstrap assets Dec 12, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
openshift/installer#879 merged that switches to the new bootstrap manifests. So we can drop the old ones now.
@ashcrow
Copy link
Member

ashcrow commented Dec 12, 2018

/test e2e-aws

@ashcrow
Copy link
Member

ashcrow commented Dec 12, 2018

Failure is infra related:

level=error msg="\t* aws_instance.master.0: Error launching source instance: timeout while waiting for state to become 'success' (timeout: 30s)"

@ashcrow
Copy link
Member

ashcrow commented Dec 12, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ashcrow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,ashcrow]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashcrow
Copy link
Member

ashcrow commented Dec 12, 2018

/test e2e-aws

@cgwalters
Copy link
Member

My locally-built mcc (while hacking on #230 ) is falling over with a spam of:

E1212 22:08:13.004611       1 render.go:65] could not find expected template directory /etc/mcc/templates/_base                                                                                                   
I1212 22:08:13.206327       1 template_controller.go:302] Error syncing controllerconfig openshift-machine-config-operator/machine-config-controller: platform libvirt unsupported  

Should this fix it?

@abhinavdahiya
Copy link
Contributor Author

My locally-built mcc (while hacking on #230 ) is falling over with a spam of:

E1212 22:08:13.004611       1 render.go:65] could not find expected template directory /etc/mcc/templates/_base                                                                                                   
I1212 22:08:13.206327       1 template_controller.go:302] Error syncing controllerconfig openshift-machine-config-operator/machine-config-controller: platform libvirt unsupported  

Should this fix it?

Hmm, this doesn't seem related...

@cgwalters
Copy link
Member

OK, I think the problem is my cluster install just predates the original PR:

  machine-config-controller                     https://github.com/openshift/machine-config-operator                       bf4341308896665b121a101b0fdcd52e4cf68f8e

@cgwalters
Copy link
Member

And it doesn't look like there's a new release payload with it that was accepted.

@openshift-merge-robot openshift-merge-robot merged commit 57e6948 into openshift:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants