reduce permissions on bootstrap kubeconfig used by masters #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift/machine-config-operator#226 sets up all the `manifests` required to approve CSRs for masters
openshift-ci-robot
added
size/M
|
/test e2e-aws |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abhinavdahiya
added a commit
to abhinavdahiya/machine-config-operator
that referenced
this pull request
Dec 12, 2018
openshift/installer#879 merged that switches to the new bootstrap manifests. So we can drop the old ones now.
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Jan 10, 2019
…o 1 day The 30 minutes validity was necessary as before openshift#879 the client certificate provided cluster admin rights. But after openshift#879 the client certificate only has access to CSR endpoint. Therefore, we can safely increase the validity to something longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the master nodes have a kubeconfig served from bootstrap node that has
adminpriviledges, but only for 30 mins. This PR reduces the permissions on that kubeconfig to only allow CSR creation.Addition of clusterrolebindings from openshift/machine-config-operator#226 (
csr-approver-role-binding.yamlandcsr-bootstrapper-role-binding.yaml) allow kubelets to create a CSR and get that CSR autoapproved from the controller manager.Requires openshift/machine-config-operator#226
/cc @wking @aaronlevy