Add ovirt as a platform #767

rgolangh · 2019-05-16T14:24:56Z

Adding the files needed to make ovirt a provider of configs.

Fixes: #766

Added manifests and templates for ovirt platform. This is the same solution like baremetal uses for networking so the yamls are almost identical.

- What I did

To test this I'm running make update && make image and pushing the container to quay.io. Then I modify my IPI installer to pull this image during bootstrap.

Related: openshift/enhancements#61

- Description for the changelog
Adding the manifest, templates and controller handling for oVirt platform.

openshift-ci-robot · 2019-05-16T14:25:14Z

Hi @rgolangh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cgwalters · 2019-05-16T14:29:25Z

openshift/api#314
needs to land first so:

/hold

Also it looks like you have some unnecessary .gitkeep stuff that's no longer needed after: #653

ashcrow · 2019-05-31T13:15:53Z

pkg/controller/template/test_data/controller_config_ovirt.yaml

+ etcdDiscoveryDomain: "my-test-cluster.metalkube.org"
+ etcdInitialCount: 3
+ platform: "ovirt"
+ etcdCAData: OHVtbXkgZXRjZC1jYQo=


Just curious, why a different dummy encoded string versus the others?

pkg/controller/template/test_data/controller_config_ovirt.yaml

hack/build-image.sh

pkg/apis/machineconfiguration.openshift.io/v1/types.go

pkg/controller/container-runtime-config/container_runtime_config_controller.go

cmd/machine-config-controller/start.go

pkg/operator/bootstrap.go

pkg/operator/cluster-infrastructure.yaml

pkg/operator/render.go

runcom · 2019-07-10T10:49:40Z

Just for reference, this is an example of how a platform has been added after support has landed into the installer #907 (your PR here also adds templates but that's ok ofc)

kikisdeliveryservice · 2019-10-17T17:27:11Z

/ok-to-test

kikisdeliveryservice · 2019-10-17T17:29:10Z

Will defer to @tux-o-matic @celebdor @cybertron to final approve as there is an open issue here: #767 (comment)

And it should be resolved/settled.

rgolangh · 2019-10-17T17:35:40Z

Will defer to @tux-o-matic @celebdor @cybertron to final approve as there is an open issue here: #767 (comment)

And it should be resolved/settled.

Uploading a version which drops the resource definition - its irrelevant for static pods and have nothing to do with it being on infra VMs or not.

oVirt is similar to baremetal platform, and needs the network setup which is described in this doc https://github.com/openshift/installer/blob/master/docs/design/baremetal/networking-infrastructure.md Fixes: openshift#766 Signed-off-by: Roy Golan <rgolan@redhat.com>

Signed-off-by: Roy Golan <rgolan@redhat.com>

kikisdeliveryservice · 2019-10-17T22:50:15Z

/lgtm

kikisdeliveryservice · 2019-10-17T22:50:42Z

btw: I dont know where ci stands, so might have to be patient on it merging.

kikisdeliveryservice · 2019-10-17T22:51:51Z

ah didnt realize i did the initial approval. :(

@runcom PTAL

/lgtm cancel

kikisdeliveryservice

no idea why my approval tag just got deleted.. :(

kikisdeliveryservice · 2019-10-18T03:26:18Z

/retest

runcom · 2019-10-18T08:38:54Z

/retest

Following the fixed proposed on openshift#1125 Signed-off-by: Roy Golan <rgolan@redhat.com>

kikisdeliveryservice · 2019-10-18T17:17:15Z

/skip

runcom · 2019-10-18T17:30:01Z

looks sane to me

/lgtm

openshift-ci-robot · 2019-10-18T17:30:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kikisdeliveryservice, rgolangh, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-10-18T18:20:19Z

@rgolangh: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-disruptive	2995529fdcd2b668dd35efe85a93bd5c81535255	link	`/test e2e-aws-disruptive`
ci/prow/e2e-aws-op	f5e6e806764d58839bec2cc641b86bdf29b51473	link	`/test e2e-aws-op`
ci/prow/e2e-gcp-upgrade	`f84c3b6`	link	`/test e2e-gcp-upgrade`
ci/prow/e2e-aws-scaleup-rhel7	`2a05230`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kikisdeliveryservice · 2019-10-18T18:35:45Z

/retest

openshift-ci-robot requested review from kikisdeliveryservice and runcom May 16, 2019 14:25

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2019

rgolangh force-pushed the master branch 2 times, most recently from 6bed795 to 7a0c83e Compare May 23, 2019 20:59

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2019

rgolangh force-pushed the master branch from 7a0c83e to 05e9805 Compare May 29, 2019 14:05

ashcrow reviewed May 31, 2019

View reviewed changes

pkg/controller/template/test_data/controller_config_ovirt.yaml Outdated Show resolved Hide resolved

kikisdeliveryservice mentioned this pull request Jun 3, 2019

bm/ovirt: pass API_VIP/DNS_VIP from cluster config/installer and render templates with it #812

Closed

rgolangh force-pushed the master branch 3 times, most recently from 885f1d8 to 7aab174 Compare June 4, 2019 07:27

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2019

rgolangh force-pushed the master branch from 7aab174 to d452a72 Compare July 10, 2019 10:03

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 10, 2019

rgolangh force-pushed the master branch from d452a72 to 6109438 Compare July 10, 2019 10:06

runcom reviewed Jul 10, 2019

View reviewed changes

rgolangh force-pushed the master branch from 6109438 to 6490ab5 Compare July 10, 2019 10:57

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2019

rgolangh force-pushed the master branch from 6490ab5 to 6f7fa34 Compare July 16, 2019 08:36

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2019

rgolangh requested a review from runcom October 17, 2019 17:27

rgolangh added 2 commits October 17, 2019 21:28

operator: reduce bootstrap code complexity

f84c3b6

Signed-off-by: Roy Golan <rgolan@redhat.com>

rgolangh force-pushed the master branch from f8f0f56 to f84c3b6 Compare October 17, 2019 18:28

openshift-ci-robot assigned kikisdeliveryservice Oct 17, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2019

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2019

kikisdeliveryservice approved these changes Oct 17, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019

ovirt: adding resources request to static pods

2a05230

Following the fixed proposed on openshift#1125 Signed-off-by: Roy Golan <rgolan@redhat.com>

rgolangh force-pushed the master branch from 79773cc to 2a05230 Compare October 18, 2019 12:39

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2019

openshift-merge-robot merged commit 951d330 into openshift:master Oct 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ovirt as a platform #767

Add ovirt as a platform #767

rgolangh commented May 16, 2019 •

edited

Loading

openshift-ci-robot commented May 16, 2019

cgwalters commented May 16, 2019

ashcrow May 31, 2019

runcom commented Jul 10, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

rgolangh commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice left a comment

kikisdeliveryservice commented Oct 18, 2019

runcom commented Oct 18, 2019

kikisdeliveryservice commented Oct 18, 2019

runcom commented Oct 18, 2019

openshift-ci-robot commented Oct 18, 2019

openshift-ci-robot commented Oct 18, 2019 •

edited

Loading

kikisdeliveryservice commented Oct 18, 2019

Add ovirt as a platform #767

Add ovirt as a platform #767

Conversation

rgolangh commented May 16, 2019 • edited Loading

openshift-ci-robot commented May 16, 2019

cgwalters commented May 16, 2019

ashcrow May 31, 2019

Choose a reason for hiding this comment

runcom commented Jul 10, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

rgolangh commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice commented Oct 17, 2019

kikisdeliveryservice left a comment

Choose a reason for hiding this comment

kikisdeliveryservice commented Oct 18, 2019

runcom commented Oct 18, 2019

kikisdeliveryservice commented Oct 18, 2019

runcom commented Oct 18, 2019

openshift-ci-robot commented Oct 18, 2019

openshift-ci-robot commented Oct 18, 2019 • edited Loading

kikisdeliveryservice commented Oct 18, 2019

rgolangh commented May 16, 2019 •

edited

Loading

openshift-ci-robot commented Oct 18, 2019 •

edited

Loading