Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on Devfile volume size support #2511

Closed
maysunfaisal opened this issue Jan 14, 2020 · 8 comments
Closed

Discussion on Devfile volume size support #2511

maysunfaisal opened this issue Jan 14, 2020 · 8 comments
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@maysunfaisal
Copy link
Contributor

maysunfaisal commented Jan 14, 2020

[kind/Feature]

Which functionality do you think we should add?

Currently, a devfile https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-web-spring/devfile.yaml has no option to configure size for a volume.

The Devfile schema does not mention it either - https://github.com/redhat-developer/devfile/blob/master/docs/devfile.json

We should have an option to mention the volume size. On the odo contributor's meeting, we discussed possible avenues:

  • size could be mentioned in the devfile under the volumes section
  • size could be mentioned in a global preference file that takes affect for all the devfiles(this is a short term solution if the devfile proposed change is not accepted)

Why is this needed?

When working for issue #2472, noticed that if we want odo to adopt the devfile, there is currently no way to configure a volume's size. This is currently present as an option in config.yaml and will be nice to have when consuming the devfile instead of having a default 1Gi like odo did previously.

@maysunfaisal
Copy link
Contributor Author

/area devfile

@openshift-ci-robot openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Jan 14, 2020
@maysunfaisal
Copy link
Contributor Author

/area storage

@maysunfaisal

This comment has been minimized.

@kadel
Copy link
Member

kadel commented Mar 2, 2020

  • size could be mentioned in the devfile under the volumes section

We need to make sure that this doesn't get lost, and size is added to Devfile v2 specification.

UPDATE: already captured in devfile/api#14

  • size could be mentioned in a global preference file that takes affect for all the devfiles(this is a short term solution if the devfile proposed change is not accepted)

+1 We need this as for term solution before we can switch to devfile v2

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 5, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants