-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion on Devfile volume size support #2511
Comments
/area devfile |
/area storage |
This comment has been minimized.
This comment has been minimized.
We need to make sure that this doesn't get lost, and size is added to Devfile v2 specification. UPDATE: already captured in devfile/api#14
+1 We need this as for term solution before we can switch to devfile v2 |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[kind/Feature]
Which functionality do you think we should add?
Currently, a devfile https://github.com/eclipse/che-devfile-registry/blob/master/devfiles/java-web-spring/devfile.yaml has no option to configure size for a volume.
The Devfile schema does not mention it either - https://github.com/redhat-developer/devfile/blob/master/docs/devfile.json
We should have an option to mention the volume size. On the odo contributor's meeting, we discussed possible avenues:
volumes
sectionWhy is this needed?
When working for issue #2472, noticed that if we want odo to adopt the devfile, there is currently no way to configure a volume's size. This is currently present as an option in config.yaml and will be nice to have when consuming the devfile instead of having a default
1Gi
like odo did previously.The text was updated successfully, but these errors were encountered: