Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the latest java image ubi8/openjdk-11 in odo supported list #4206

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Adding the latest java image ubi8/openjdk-11 in odo supported list #4206

merged 2 commits into from
Nov 25, 2020

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?
/kind failing-test
/kind feature

What does does this PR do / why we need it:

There is latest java image difference on 4.6 and 4.5 cluster. So, adding ubi8/openjdk-11 image as supported will unblock enabling odo periodic job on 4.6 cluster #4138

Which issue(s) this PR fixes:

Fixes - part of issue #4138

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Latest java image on 4.6 should execute successfully for odo

@openshift-ci-robot openshift-ci-robot added kind/failing-test kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Nov 9, 2020
@prietyc123 prietyc123 mentioned this pull request Nov 9, 2020
Merged
@dharmit
Copy link
Member

dharmit commented Nov 18, 2020

/hold

There are issues with getting an updated image out. If this get erroneously merged before those issues are resolved, we'll have another set of problems in terms of failing integration tests.

@prietyc123 @mohammedzee1000 I'm sure you folks know better than me when to un-hold this. 😉

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 18, 2020
@mohammedzee1000
Copy link
Contributor

Can we update the default bootstrapper image to 1.1.7?

@prietyc123
Copy link
Contributor Author

Updated the latest init image version. So removing the hold.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 24, 2020
mohammedzee1000
mohammedzee1000 reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2020
dharmit
dharmit reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 24, 2020
@mohammedzee1000 mohammedzee1000 mentioned this pull request Nov 24, 2020
Merged
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 585fd6d into redhat-developer:master Nov 25, 2020
zhengxiaomei123 added a commit to zhengxiaomei123/odo that referenced this pull request Dec 18, 2020
@zhengxiaomei123
Add same fix with redhat-developer#4206.
f5fcdc1 
Add some fix for importing java imagestream.
@zhengxiaomei123 zhengxiaomei123 mentioned this pull request Dec 18, 2020
Merged
4 tasks
zhengxiaomei123 added a commit to zhengxiaomei123/odo that referenced this pull request Jan 13, 2021
@zhengxiaomei123
Add same fix with redhat-developer#4206.
4c3c28d 
Add some fix for importing java imagestream.
zhengxiaomei123 added a commit to zhengxiaomei123/odo that referenced this pull request Jan 15, 2021
@zhengxiaomei123
Add same fix with redhat-developer#4206.
e3e55f6 
Add some fix for importing java imagestream.
zhengxiaomei123 added a commit to zhengxiaomei123/odo that referenced this pull request Jan 15, 2021
@zhengxiaomei123
Add same fix with redhat-developer#4206.
cd1c5ee 
Add some fix for importing java imagestream.
openshift-merge-robot pushed a commit that referenced this pull request Jan 20, 2021
@zhengxiaomei123
Add same fix with #4206. (#4317)
5544b25 
Add some fix for importing java imagestream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 mohammedzee1000 left review comments

@dharmit dharmit dharmit left review comments

@mik-dass mik-dass Awaiting requested review from mik-dass

Assignees

@mohammedzee1000 mohammedzee1000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prietyc123 @dharmit @mohammedzee1000 @openshift-ci-robot @openshift-bot @openshift-merge-robot