Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 4.6 cluster for odo pr test #4138

Closed
2 tasks
prietyc123 opened this issue Oct 23, 2020 · 7 comments
Closed
2 tasks

Enable 4.6 cluster for odo pr test #4138

prietyc123 opened this issue Oct 23, 2020 · 7 comments
Assignees
@prietyc123
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind

Comments

@prietyc123
Copy link
Contributor

/kind user-story

User Story

As a user I want to run prow jobs on 4.6 cluster

Acceptance Criteria

  • Fixing the blockers for enabling 4.6 cluster on PRs
  • Jobs should successfully run on 4.6 ocp cluster.

Note: There is already WIP PR openshift/release#10346 which has some blockers. We need to fix those blockers from odo side.

Links

  • Feature Request: NA
  • Related issue: NA

/kind user-story
@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Oct 23, 2020
@prietyc123 prietyc123 self-assigned this Oct 23, 2020
@prietyc123 prietyc123 added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Oct 23, 2020
@dharmit
Copy link
Member

dharmit commented Oct 23, 2020

Since 4.6 is the latest and the greatest OCP version out there, I'm all game for running tests on it. But, I would request that we stick to testing on the specific version of OCP (4.6.x) that CRC ships with. Currently, CRC ships with 4.5.14 but our CI is running on 4.5.15, if I'm not wrong.

I'm requesting this because most devs on the odo team are developing against a minikube or a CRC box. And, I think it's safe to assume that our end users would be using that as well.

@prietyc123
Copy link
Contributor Author

CRC ships with 4.5.14 but our CI is running on 4.5.15

Seems @amitkrout had some progress to fix your concern through this pr openshift/release#11013. @amitkrout Can you please update it.

@amitkrout
Copy link
Contributor

CRC ships with 4.5.14 but our CI is running on 4.5.15

Seems @amitkrout had some progress to fix your concern through this pr openshift/release#11013. @amitkrout Can you please update it.

My bad. I could not follow up my pr since it hit the last platform failure. Anyway i have rebased my pr, as @prietyc123 is on PTO entire this week, so @anandrkskd Please keep eyes on this pr and ping me over slack if it fails again.

@prietyc123
Copy link
Contributor Author

Some of the issue needs to be resolved in order to complete this.

Issues:

So comparatively we are blocked on enabling 4.6 cluster too.

@prietyc123 prietyc123 added status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) labels Nov 5, 2020
@prietyc123
Copy link
Contributor Author

prietyc123 commented Nov 9, 2020 •
edited by openshift-ci-robot
Loading

I have executed our test locally on 4.6 latest stable version and now observing the latest java images are also unsupported from odo side which was not the case before with the unstable build. However I have run basic s2i functionality of odo with image ubi8/openjdk-11 and it works fine which means we need to add it as supported and release init image the same way as redhat-developer/odo-init-image#72 (comment) . @mohammedzee1000 I have opened a pr redhat-developer/odo-init-image#74 , could you please merge it forcibly and initiate a release process. Afterwards I will open a PR on odo repo to add it in supported list.

$ oc -n openshift get is java -o yaml
apiVersion: image.openshift.io/v1
kind: ImageStream
metadata:
  name: java
  namespace: openshift
spec:
  lookupPolicy:
    local: false
  tags:
[...]
  - annotations:
      description: Build and run Java applications using Maven.
      iconClass: icon-rh-openjdk
      openshift.io/display-name: Java (Latest)
      sampleContextDir: undertow-servlet
      sampleRepo: https://github.com/jboss-openshift/openshift-quickstarts
      supports: java
      tags: builder,java,openjdk
      version: latest
    from:
      kind: ImageStreamTag
      name: [openjdk-11](https://issues.redhat.com/browse/openjdk-11)-ubi8
    generation: 1
    importPolicy: {}
    name: latest
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run Java applications using Maven and OpenJDK 11.
      iconClass: icon-rh-openjdk
      openshift.io/display-name: Red Hat OpenJDK 11 (RHEL 7)
      sampleContextDir: undertow-servlet
      sampleRepo: https://github.com/jboss-openshift/openshift-quickstarts
      supports: java:11,java
      tags: builder,java,openjdk
      version: "11"
    from:
      kind: DockerImage
      name: registry.redhat.io/openjdk/openjdk-11-rhel7:latest
    generation: 2
    importPolicy: {}
    name: [openjdk-11](https://issues.redhat.com/browse/openjdk-11)-el7
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run Java applications using Maven and OpenJDK 11.
      iconClass: icon-rh-openjdk
      openshift.io/display-name: Red Hat OpenJDK 11 (UBI 8)
      sampleContextDir: undertow-servlet
      sampleRepo: https://github.com/jboss-openshift/openshift-quickstarts
      supports: java:11,java
      tags: builder,java,openjdk
      version: "11"
    from:
      kind: DockerImage
      name: registry.redhat.io/ubi8/openjdk-11:latest
    generation: 2
    importPolicy: {}
    name: [openjdk-11](https://issues.redhat.com/browse/openjdk-11)-ubi8
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run Java applications using Maven and OpenJDK 8.
      iconClass: icon-rh-openjdk
      openshift.io/display-name: Red Hat OpenJDK 8 (RHEL 7)
      sampleContextDir: undertow-servlet
      sampleRepo: https://github.com/jboss-openshift/openshift-quickstarts
      supports: java:8,java
      tags: builder,java,openjdk
      version: "8"
    from:
      kind: DockerImage
      name: registry.redhat.io/redhat-[openjdk-18](https://issues.redhat.com/browse/openjdk-18)/openjdk18-openshift:latest
    generation: 2
    importPolicy: {}
    name: [openjdk-8](https://issues.redhat.com/browse/openjdk-8)-el7
    referencePolicy:
      type: Local
  - annotations:
      description: Build and run Java applications using Maven and OpenJDK 8.
      iconClass: icon-rh-openjdk
      openshift.io/display-name: Red Hat OpenJDK 8 (UBI 8)
      sampleContextDir: undertow-servlet
      sampleRepo: https://github.com/jboss-openshift/openshift-quickstarts
      supports: java:8,java
      tags: builder,java,openjdk
      version: "8"
    from:
      kind: DockerImage
      name: registry.redhat.io/ubi8/openjdk-8:latest
    generation: 2
    importPolicy: {}
    name: [openjdk-8](https://issues.redhat.com/browse/openjdk-8)-ubi8
    referencePolicy:
      type: Local
status:
  dockerImageRepository: image-registry.openshift-image-registry.svc:5000/openshift/java
  tags:
 [...]
  - items:
    - created: "2020-11-09T05:45:23Z"
      dockerImageReference: registry.redhat.io/ubi8/openjdk-11@sha256:5743bc7c45fce643862773cd1b4e9738cca2ea223c1e4566d71d3788c7ab4b38
      generation: 2
      image: sha256:5743bc7c45fce643862773cd1b4e9738cca2ea223c1e4566d71d3788c7ab4b38
    tag: latest
  - items:
    - created: "2020-11-09T05:45:23Z"
      dockerImageReference: registry.redhat.io/openjdk/openjdk-11-rhel7@sha256:442eda2f44aba32a17aab2d47d36543d0b84732b7553bc5db2e90e1d9ba55d14
      generation: 2
      image: sha256:442eda2f44aba32a17aab2d47d36543d0b84732b7553bc5db2e90e1d9ba55d14
    tag: [openjdk-11](https://issues.redhat.com/browse/openjdk-11)-el7
  - items:
    - created: "2020-11-09T05:45:23Z"
      dockerImageReference: registry.redhat.io/ubi8/openjdk-11@sha256:5743bc7c45fce643862773cd1b4e9738cca2ea223c1e4566d71d3788c7ab4b38
      generation: 2
      image: sha256:5743bc7c45fce643862773cd1b4e9738cca2ea223c1e4566d71d3788c7ab4b38
    tag: [openjdk-11](https://issues.redhat.com/browse/openjdk-11)-ubi8
  - items:
    - created: "2020-11-09T05:45:23Z"
      dockerImageReference: registry.redhat.io/redhat-[openjdk-18](https://issues.redhat.com/browse/openjdk-18)/openjdk18-openshift@sha256:fa5f725ba5d0ed29f680a21d49e87d88ef0bad3db83158496eda33533cca10f8
      generation: 2
      image: sha256:fa5f725ba5d0ed29f680a21d49e87d88ef0bad3db83158496eda33533cca10f8
    tag: [openjdk-8](https://issues.redhat.com/browse/openjdk-8)-el7
  - items:
    - created: "2020-11-09T05:45:23Z"
      dockerImageReference: registry.redhat.io/ubi8/openjdk-8@sha256:43a0bf425a428380a741b6c168a0de438a267bfcd31e982e23c6965d5dfeb9e6
      generation: 2
      image: sha256:43a0bf425a428380a741b6c168a0de438a267bfcd31e982e23c6965d5dfeb9e6
    tag: [openjdk-8](https://issues.redhat.com/browse/openjdk-8)-ubi8

This was referenced Nov 9, 2020
Merged
Merged
@prietyc123
Copy link
Contributor Author

Enabling 4.6 is blocked on odo init release 1.1.7 due to https://projects.engineering.redhat.com/browse/CLOUDBLD-3483

@prietyc123 prietyc123 added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Nov 18, 2020
@prietyc123 prietyc123 removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Nov 27, 2020
@prietyc123
Copy link
Contributor Author

The acceptance criteria has been via PR openshift/release#10346. So closing this issue.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prietyc123 prietyc123

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dharmit @amitkrout @openshift-ci-robot @prietyc123