Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ubi8/nodejs-12 image as supported #72

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Adding ubi8/nodejs-12 image as supported #72

merged 1 commit into from
Oct 19, 2020

Conversation

prietyc123
Copy link
Contributor

Adding ubi8/nodejs-12 image as supported because there is latest image difference between 4.5 and 4.6 cluster. More details are in issue redhat-developer/odo#4016 . There is also one pr on odo redhat-developer/odo#4070.

@prietyc123
Copy link
Contributor Author

ping @kadel

@kadel
Copy link
Member

kadel commented Oct 2, 2020 •
edited
Loading

tests are failing. can you check why?

@prietyc123 prietyc123 changed the title Adding ubi8/nodejs-12 image as supported [WIP] Adding ubi8/nodejs-12 image as supported Oct 2, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2020
@amitkrout
Copy link
Contributor

@prietyc123 Can you please include #64 changes so that we can verify and push it in a single go. thanks

@amitkrout amitkrout mentioned this pull request Oct 2, 2020
Closed
@kadel
Copy link
Member

kadel commented Oct 7, 2020 •
edited
Loading

@amitkrout

@prietyc123 Can you please include #64 changes so that we can verify and push it in a single go. thanks

Why not continue in the original PR? This PR is addressing a different issue.

@kadel kadel mentioned this pull request Oct 7, 2020
Merged
4 tasks
@prietyc123 prietyc123 mentioned this pull request Oct 15, 2020
Closed
@kadel
Copy link
Member

kadel commented Oct 19, 2020

The test won't pass until redhat-developer/odo#4070 gets merged, redhat-developer/odo#4070 won't pass until this one is merged and a new init image is released.

The next steps:

/approve
/lgtm
/title Adding ubi8/nodejs-12 image as supported

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2020
@prietyc123 prietyc123 changed the title [WIP] Adding ubi8/nodejs-12 image as supported Adding ubi8/nodejs-12 image as supported Oct 19, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0db91b6 into redhat-developer:master Oct 19, 2020
@prietyc123 prietyc123 mentioned this pull request Nov 9, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@kadel kadel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prietyc123 @kadel @amitkrout @openshift-ci-robot @openshift-merge-robot