Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable 4.6 cluster for odo test on pr and periodic jobs #10346

Merged
merged 4 commits into from
Nov 30, 2020
Merged

Enable 4.6 cluster for odo test on pr and periodic jobs #10346

merged 4 commits into from
Nov 30, 2020

Conversation

prietyc123
Copy link
Contributor

Enable 4.6 cluster for odo test on periodic jobs to check the stability of test according to upcoming version

Ping @amitkrout

@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch from aa50d19 to b1749da Compare July 21, 2020 07:22
@prietyc123 prietyc123 mentioned this pull request Jul 21, 2020
Closed
@prietyc123
Copy link
Contributor Author

/retest

@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch from b1749da to b933540 Compare August 3, 2020 13:19
This was referenced Aug 3, 2020
Closed
Merged
@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch from b933540 to 7e525f0 Compare August 10, 2020 14:21
@prietyc123
Copy link
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/10346/rehearse-10346-periodic-ci-openshift-odo-master-v4.6-integration-e2e-periodic/1292828790027718656#1:build-log.txt%3A748 is a flake already tracked here - redhat-developer/odo#3610

/retest

@prietyc123
Copy link
Contributor Author

/retest

@amitkrout
Copy link
Contributor 

Error from server (AlreadyExists): error when creating "STDIN": subscriptions.operators.coreos.com "mongodb-enterprise" already exists
Error from server (AlreadyExists): error when creating "STDIN": subscriptions.operators.coreos.com "etcd" already exists
Error from server (AlreadyExists): error when creating "STDIN": subscriptions.operators.coreos.com "service-binding-operator" already exists

Because of this all the operator hub tests are failing

@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch from 7e525f0 to 7c00824 Compare August 13, 2020 04:43
amitkrout
amitkrout suggested changes Aug 13, 2020
View reviewed changes
ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml
ci-operator.openshift.io/prowgen-controlled: "true"
ci-operator.openshift.io/variant: v4.6
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: periodic-ci-openshift-odo-master-v4.6-integration-e2e-periodic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prow job generator does not carry the notification config. First you need to add it manually then run make jobs to confirm the change.

reporter_config:
    slack:
      channel: '#odo-notifications'
      job_states_to_report:
      - success
      - failure
      - error
      report_template: '{{if eq .Status.State "success"}} :rainbow: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> :rainbow: {{else}} :volcano: Job *{{.Spec.Job}}* ended with *{{.Status.State}}*. <{{.Status.URL}}|View logs> :volcano: {{end}}'

For reference check - https://github.com/openshift/release/blob/master/ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml#L17-L24

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh... missed it thanks for pointing it out 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@prietyc123 prietyc123 mentioned this pull request Aug 24, 2020
Merged
4 tasks
@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch 2 times, most recently from 79cf8dd to b286d2f Compare August 25, 2020 10:33
@prietyc123
Copy link
Contributor Author

/retest

@stevekuznetsov
Copy link
Contributor

/test pj-rehearse

@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch 2 times, most recently from 2887eb9 to d3f6cfa Compare September 7, 2020 07:29
@prietyc123 prietyc123 mentioned this pull request Sep 7, 2020
Closed
@amitkrout
Copy link
Contributor

Blocked due to redhat-developer/odo#3882

@prietyc123
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

@prietyc123: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-odo-master-v4.6-integration-e2e-periodic da5aeca2acd1df19e807bd9583f47852a888538d link /test pj-rehearse
ci/prow/pj-rehearse da5aeca2acd1df19e807bd9583f47852a888538d link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@prietyc123 prietyc123 mentioned this pull request Oct 23, 2020
Closed
2 tasks
@prietyc123 prietyc123 force-pushed the Enable4.6ClsuterOnPeriodicJobs branch from da5aeca to 40e4036 Compare November 6, 2020 09:12
@prietyc123
Copy link
Contributor Author

/retest

@prietyc123 prietyc123 changed the title Enable 4.6 cluster for odo test on periodic jobs Enable 4.6 cluster for odo test on pr and periodic jobs Nov 30, 2020
@mik-dass
Copy link

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020
@amitkrout
Copy link
Contributor

Config file and the generated job file along with few manual update in the job file looks good to me.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, mik-dass, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8734dd9 into openshift:master Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

@prietyc123: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-odo-master-periodics.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml
    • key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-odo-master__v4.5.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.5.yaml
    • key openshift-odo-master__v4.6.yaml using file ci-operator/config/openshift/odo/openshift-odo-master__v4.6.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-odo-master-periodics.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-periodics.yaml
    • key openshift-odo-master-presubmits.yaml using file ci-operator/jobs/openshift/odo/openshift-odo-master-presubmits.yaml

In response to this:

Enable 4.6 cluster for odo test on periodic jobs to check the stability of test according to upcoming version

Ping @amitkrout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout requested changes

@dharmit dharmit Awaiting requested review from dharmit

@mik-dass mik-dass Awaiting requested review from mik-dass

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prietyc123 @amitkrout @stevekuznetsov @openshift-ci-robot @mik-dass @openshift-merge-robot