Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming entrypoint scripts to use new job #4419

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Renaming entrypoint scripts to use new job #4419

merged 1 commit into from
Feb 12, 2021

Conversation

mohammedzee1000
Copy link
Contributor

  • 4.6 will now run the old presubmit-all script
  • psi will run as 4.6-e2e-4x-psi

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

@mohammedzee1000
Renaming entrypoint scripts to use new job
5edb73b 
 - 4.6 will now run the old presubmit-all script
 - psi will run as 4.6-e2e-4x-psi

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Feb 9, 2021
@anandrkskd
Copy link
Contributor

anandrkskd commented Feb 9, 2021 •
edited
Loading

@mohammedzee1000 should we also remove the old presubmit-all script ? or we are going to use it somewhere

@mohammedzee1000
Copy link
Contributor Author

@anandrkskd Eventually yes, not right now.

@mohammedzee1000
Copy link
Contributor Author

Interesting. Wonder why it failed on nodejs-14 o_O

Summarizing 1 Failure:
[Fail] odo supported images e2e tests odo supported private registry images deployment [It] Should be able to verify the nodejs-14 image 
/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
Ran 30 of 30 Specs in 1140.566 seconds
FAIL! -- 29 Passed | 1 Failed | 0 Pending | 0 Skipped
Ginkgo ran 1 suite in 19m2.657091023s
Test Suite Failed
make: *** [test-e2e-all] Error 1
+ error=true
+ '[' true ']'

anycase lets try one more time
/retest

@anandrkskd
Copy link
Contributor

its tracked under #4416

@mohammedzee1000
Copy link
Contributor Author

/test v4.6-integration-e2e

@mohammedzee1000
Copy link
Contributor Author

Same fail again

@anandrkskd anandrkskd mentioned this pull request Feb 10, 2021
Closed
@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 11, 2021
@mohammedzee1000
Copy link
Contributor Author

/refresh

1 similar comment
@mohammedzee1000
Copy link
Contributor Author

/refresh

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@rnapoles-rh
Copy link
Contributor

/lgtm

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mohammedzee1000
Copy link
Contributor Author

/retest

1 similar comment
@mohammedzee1000
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2021

@mohammedzee1000: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-e2e-4x-psi 5edb73b link /test v4.6-e2e-4x-psi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7b3b511 into redhat-developer:master Feb 12, 2021
@rnapoles-rh rnapoles-rh mentioned this pull request Feb 9, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnapoles-rh rnapoles-rh rnapoles-rh approved these changes

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees

@anandrkskd anandrkskd

@rnapoles-rh rnapoles-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mohammedzee1000 @openshift-ci-robot @anandrkskd @openshift-bot @rnapoles-rh @openshift-merge-robot