Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding link to Connector extension on Open VSX #4434

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

brianking
Copy link
Contributor

@brianking brianking commented Feb 15, 2021

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring

Documentation changes: Please include [skip ci] in your commit message as well

/kind documentation
[skip ci]

What does does this PR do / why we need it:

Open VSX is an open registry for VS Code extensions. OpenShift Connector is listed there as well.

Which issue(s) this PR fixes:

Fixes #?

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

Open VSX is an open registry for VS Code extensions. OpenShift Connector is listed there as well.
@openshift-ci-robot
Copy link
Collaborator

Hi @brianking. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Feb 15, 2021
@brianking
Copy link
Contributor Author

/assign @dharmit

@dharmit
Copy link
Member

dharmit commented Feb 16, 2021

@brianking thanks for your contirbution!

/ok-to-test
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Feb 16, 2021
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianking, dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Feb 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Feb 16, 2021

@brianking: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-e2e-4x-psi f199d80 link /test v4.6-e2e-4x-psi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@brianking
Copy link
Contributor Author

/retest

@dharmit
Copy link
Member

dharmit commented Feb 17, 2021

Hey Brian, this PR's merged. A retest isn't going to do test anything. Is there something specific you're looking for?

@brianking
Copy link
Contributor Author

@dharmit Noted. I was just blindly following instructions from the comment above. Apologies, I'm not familiar with the project's build/merge system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants