-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BZ1860721: adding certificate customizations #34976
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: b533987 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6101b85f7e2c700007e6f016 😎 Browse the preview: https://deploy-preview-34976--osdocs.netlify.app |
@tsze-redhat, will you PTAL? It's easier to track the important part of this change by checking out the preview. |
Sorry I didn't notice this before. step 2 c has Do you know where that comes from? It isn't a necessary step, I think. @wking Correct me here please. Other than the above, LGTM. Thanks. |
@tsze-redhat, it's applying the same GCP + restricted customizations that you approved here. |
and I asked the same questions there too. :) Sorry. LGTM Thanks. |
Thank you for taking a look! I am glad that you didn't have a new concern about this specific implementation and that it looks good. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
https://bugzilla.redhat.com/show_bug.cgi?id=1860721
4.6+
Preview: https://deploy-preview-34976--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp.html#installation-initializing_installing-restricted-networks-gcp