-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should truncate large env vars in osc describe
#1745
Comments
this would require a "verbose" option on describe CC @fabianofranz |
We have similar problems with really long annotation values, but considering just trimming these for now |
Also build descriptions in Since describe code is mostly upstream and "verbose" would mean adding yet another parameter to propagate throughout the stack, we sort of concluded it might be best to truncate everything unconditionally and let them use |
This could be a quick solution for the moment and avoid the need of a "verbose" flag:
|
Issues go stale after 90d of inactivity. /lifecycle stale |
…service-catalog/' changes from b758460ba7..c3e3071633 c3e3071633 origin build: add origin tooling 97ddbab chart changes for v0.1.9 (openshift#1776) b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763) 97d11cb prometheus: only return catalog specific metrics (openshift#1774) 0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775) 0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770) 28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768) ca83d18 handle binding deletion that occurs during async bind (openshift#1760) 858d467 2 of 4 fixes for golang 1.10 (openshift#1764) 656156b Add unit tests for binding and broker backends in svcat ec05486 In svcat verify service instance exists on unbind (openshift#1750) e6315a4 fix indentation from openshift#1725 (openshift#1759) 62284da Publish svcat binaries during build (openshift#1725) 8f986ae also build with golang tip and allow tip to fail (openshift#1734) 127561e use pvc for etcd volume (openshift#1684) 7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693) 4ea44c4 log the version and build date on server startup (openshift#1746) 0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743) b1da783 print schemas when describing plan in svcat (openshift#1740) 7a7fcce Add constraint for go-open-service-broker-client (openshift#1738) 3070003 Increase timeout for broker condition polling in e2e (openshift#1745) b6878f7 Avoid Setting Authentication header twice (openshift#1685) 5317111 wrap "rm -rf" with docker (openshift#1735) d7c0bf2 Allow upper case letters in Plan names (openshift#1668) 6b27ba6 Add a constraint on go-autorest (openshift#1732) b3de6ec Added validation for ServiceBinding spec ParametersFrom REVERT: b758460ba7 origin build: modify hard coded path REVERT: 871582f73a origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
…service-catalog/' changes from b758460ba7..c3e3071633 c3e3071633 origin build: add origin tooling 97ddbab chart changes for v0.1.9 (openshift#1776) b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763) 97d11cb prometheus: only return catalog specific metrics (openshift#1774) 0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775) 0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770) 28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768) ca83d18 handle binding deletion that occurs during async bind (openshift#1760) 858d467 2 of 4 fixes for golang 1.10 (openshift#1764) 656156b Add unit tests for binding and broker backends in svcat ec05486 In svcat verify service instance exists on unbind (openshift#1750) e6315a4 fix indentation from openshift#1725 (openshift#1759) 62284da Publish svcat binaries during build (openshift#1725) 8f986ae also build with golang tip and allow tip to fail (openshift#1734) 127561e use pvc for etcd volume (openshift#1684) 7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693) 4ea44c4 log the version and build date on server startup (openshift#1746) 0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743) b1da783 print schemas when describing plan in svcat (openshift#1740) 7a7fcce Add constraint for go-open-service-broker-client (openshift#1738) 3070003 Increase timeout for broker condition polling in e2e (openshift#1745) b6878f7 Avoid Setting Authentication header twice (openshift#1685) 5317111 wrap "rm -rf" with docker (openshift#1735) d7c0bf2 Allow upper case letters in Plan names (openshift#1668) 6b27ba6 Add a constraint on go-autorest (openshift#1732) b3de6ec Added validation for ServiceBinding spec ParametersFrom REVERT: b758460ba7 origin build: modify hard coded path REVERT: 871582f73a origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
…service-catalog/' changes from b758460ba7..c3e3071633 c3e3071633 origin build: add origin tooling 97ddbab chart changes for v0.1.9 (openshift#1776) b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763) 97d11cb prometheus: only return catalog specific metrics (openshift#1774) 0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775) 0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770) 28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768) ca83d18 handle binding deletion that occurs during async bind (openshift#1760) 858d467 2 of 4 fixes for golang 1.10 (openshift#1764) 656156b Add unit tests for binding and broker backends in svcat ec05486 In svcat verify service instance exists on unbind (openshift#1750) e6315a4 fix indentation from openshift#1725 (openshift#1759) 62284da Publish svcat binaries during build (openshift#1725) 8f986ae also build with golang tip and allow tip to fail (openshift#1734) 127561e use pvc for etcd volume (openshift#1684) 7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693) 4ea44c4 log the version and build date on server startup (openshift#1746) 0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743) b1da783 print schemas when describing plan in svcat (openshift#1740) 7a7fcce Add constraint for go-open-service-broker-client (openshift#1738) 3070003 Increase timeout for broker condition polling in e2e (openshift#1745) b6878f7 Avoid Setting Authentication header twice (openshift#1685) 5317111 wrap "rm -rf" with docker (openshift#1735) d7c0bf2 Allow upper case letters in Plan names (openshift#1668) 6b27ba6 Add a constraint on go-autorest (openshift#1732) b3de6ec Added validation for ServiceBinding spec ParametersFrom REVERT: b758460ba7 origin build: modify hard coded path REVERT: 871582f73a origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
For things with certs and such in env vars, the output should be truncated by default, expanded by option.
The text was updated successfully, but these errors were encountered: