Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stronger validation for tls termination type #1768

Merged
merged 1 commit into from
Apr 17, 2015
Merged

stronger validation for tls termination type #1768

merged 1 commit into from
Apr 17, 2015

Conversation

pweil-
Copy link
Contributor

@pweil- pweil- commented Apr 16, 2015

This strengthens the validation on the api server side for routes to protect against a bad tls termination type string. The router correctly ignored it but you could still create it and it was unclear why the router didn't work.

/cc @jcantrill

[vagrant@openshiftdev origin]$ cat ~/test_route.json 
{
    "apiVersion": "v1beta1",
    "kind": "Route",
    "metadata": {
        "labels": {
            "generatedby": "OpenShiftWebConsole",
            "name": "ruby-hello-world"
        },
        "name": "ruby-hello-world"
    },
    "serviceName": "ruby-hello-world",
    "tls": {
        "termination": "unsecure"
    }
}
[vagrant@openshiftdev origin]$ osc create -f ~/test_route.json 
Error: route "ruby-hello-world" is invalid: tls.termination: invalid value 'unsecure': invalid value for termination, acceptable values are edge, passthrough, reencrypt, or emtpy (no tls specified)

@pweil-
Copy link
Contributor Author

pweil- commented Apr 16, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1842/)

@jcantrill jcantrill mentioned this pull request Apr 16, 2015
Merged
@pweil- pweil- force-pushed the router-tls-validation branch 2 times, most recently from 3ce1ffb to fd78060 Compare April 16, 2015 19:14
@pweil- pweil- force-pushed the router-tls-validation branch from fd78060 to 5b735e9 Compare April 16, 2015 22:14
@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1597/) (Image: devenv-fedora_1291)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 5b735e9

openshift-bot pushed a commit that referenced this pull request Apr 17, 2015
Merge pull request #1768 from pweil-/router-tls-validation
0946a37 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 0946a37 into openshift:master Apr 17, 2015
@smarterclayton smarterclayton added the kind/bug Categorizes issue or PR as related to a bug. label Apr 23, 2015
@smarterclayton smarterclayton modified the milestone: 0.5.0 (beta3) Apr 23, 2015
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 1, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
f72ed83 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 1, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
f574d6f 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Mar 8, 2018
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
fc02f43 
…service-catalog/' changes from b758460ba7..c3e3071633

c3e3071633 origin build: add origin tooling
97ddbab chart changes for v0.1.9 (openshift#1776)
b5168a7 Add unit tests for class, instance, plan backends in svcat (openshift#1763)
97d11cb prometheus: only return catalog specific metrics (openshift#1774)
0fb00e3 Bump dependency on go-open-service-broker-client to 0.0.4 (openshift#1775)
0a9f1e4 Reset RemovedFromBrokerCatalog when broker re-adds a removed service class (openshift#1770)
28ec5ed Bump dependency on go-open-service-broker-client to 0.0.3 (openshift#1768)
ca83d18 handle binding deletion that occurs during async bind (openshift#1760)
858d467 2 of 4 fixes for golang 1.10 (openshift#1764)
656156b Add unit tests for binding and broker backends in svcat
ec05486 In svcat verify service instance exists on unbind (openshift#1750)
e6315a4 fix indentation from openshift#1725 (openshift#1759)
62284da Publish svcat binaries during build (openshift#1725)
8f986ae also build with golang tip and allow tip to fail (openshift#1734)
127561e use pvc for etcd volume (openshift#1684)
7d155e5 Ensure only href-checker runs on docs only commit (openshift#1693)
4ea44c4 log the version and build date on server startup (openshift#1746)
0db9519 allow getting and describing plans with class/plan name combo in svcat (openshift#1743)
b1da783 print schemas when describing plan in svcat (openshift#1740)
7a7fcce Add constraint for go-open-service-broker-client (openshift#1738)
3070003 Increase timeout for broker condition polling in e2e (openshift#1745)
b6878f7 Avoid Setting Authentication header twice (openshift#1685)
5317111 wrap "rm -rf" with docker (openshift#1735)
d7c0bf2 Allow upper case letters in Plan names (openshift#1668)
6b27ba6  Add a constraint on go-autorest  (openshift#1732)
b3de6ec Added validation for ServiceBinding spec ParametersFrom
REVERT: b758460ba7 origin build: modify hard coded path
REVERT: 871582f73a origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: c3e3071633b91541cf9f1000d2d5115cdd31de1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.5.0 (beta3)
Development

Successfully merging this pull request may close these issues.
3 participants
@pweil- @openshift-bot @smarterclayton