Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update aggregator to match latest kube #14676

Merged
merged 6 commits into from
Jun 16, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 15, 2017

This updates openshift to use the latest aggregation APIs.

@liggitt I didn't add comments in the existing groups, since we aren't going to have new versions in openshfit for a while.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

@jpeeler @sdodson @pmorie @derekwaynecarr @bparees @Kargakis

Be aware that the schema for APIService is being bumped to beta and being changed to match the (hopefully) final state in kube 1.7.

@bparees
Copy link
Contributor

bparees commented Jun 15, 2017

uh. so i need to go update all my cluster up stuff to use v1beta1 instead of v1alpha1?

@sdodson
Copy link
Member

sdodson commented Jun 15, 2017

@ewolinetz fyi

@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

uh. so i need to go update all my cluster up stuff to use v1beta1 instead of v1alpha1?

And you need groupPriorityMinimum and versionPriority instead of priority.

@bparees
Copy link
Contributor

bparees commented Jun 15, 2017

@deads2k how soon can we get this in the queue? i can't put the cluster up PR in the merge queue until this goes in.

@liggitt
Copy link
Contributor

liggitt commented Jun 15, 2017

@deads2k all the generated.pb.go changes with no accompanying descriptor changes are unexpected. what version of go did you run with? (and/or did you clean the built proto-generating tools after switching go versions) (gzip differences will output different gzipped manifests)

@liggitt
Copy link
Contributor

liggitt commented Jun 15, 2017

just the question on the generated.pb.go changes, LGTM otherwise

@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

just the question on the generated.pb.go changes, LGTM otherwise

@liggitt grrrr. Probably 1.8. Just normal kube env.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

reran with 1.7, no changes.

[test]

@deads2k
Copy link
Contributor Author

deads2k commented Jun 15, 2017

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 15, 2017

continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 12

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c7463bc

@smarterclayton
Copy link
Contributor

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 3d93cfb

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2304/) (Base Commit: a68db68) (PR Branch Commit: 3d93cfb)

@deads2k
Copy link
Contributor Author

deads2k commented Jun 16, 2017

@smarterclayton green if you're still manually tending

@smarterclayton smarterclayton merged commit 4aa3720 into openshift:master Jun 16, 2017
@deads2k deads2k deleted the agg-08-beta branch August 3, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants