UPSTREAM: <drop>: Use internal service/endpoints informers in aggregator #14694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait for #14676 first please |
|
I am
|
|
[test] |
1 similar comment
|
[test]
|
smarterclayton
force-pushed
the
aggregate_internal
branch
from
537eef7
to
b009d21
Compare
Until kube-proxy switches to the external endpoints informer (1.7) we need to use the same one for DNS, which means aggregator does as well. Can be removed once we move to 1.7
smarterclayton
force-pushed
the
aggregate_internal
branch
from
b009d21
to
1502cf1
Compare
smarterclayton
force-pushed
the
aggregate_internal
branch
from
1502cf1
to
f18c39c
Compare
|
Evaluated for origin test up to f18c39c |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2363/) (Base Commit: 640b50e) (PR Branch Commit: f18c39c) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until kube-proxy switches to the external endpoints informer (1.7) we
need to use the same one for DNS, which means aggregator does as well.
Can be removed once we move to 1.7
[test] @deads2k close, but no cigar