Stabilize ingressip controller unit test #20352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate flakes in the TestBasicControllerFlow test by polling fake action state rather than relying on custom fake watch consumption; the event counts on the watch are not deterministic, and so the previous assumption of two events doesn't always hold and causes a deadlock in the test's custom controller handler. Refactor the test to remove unnecessary fake watch and controller setup; just use the fake client and its built-in watch capabilities directly.
openshift-ci-robot
added
the
size/L
|
On master I can reproduce the flake with |
|
10k runs and no failures, so I think this is good assuming the assertions are valid (previously there weren't really any) |
|
/retest |
1 similar comment
|
/retest |
|
/test gcp |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test gcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate flakes in the TestBasicControllerFlow test by polling fake action
state rather than relying on custom fake watch consumption; the event counts on
the watch are not deterministic, and so the previous assumption of two events
doesn't always hold and causes a deadlock in the test's custom controller
handler.
Refactor the test to remove unnecessary fake watch and controller setup; just
use the fake client and its built-in watch capabilities directly.
Add stronger update validity assertions.
/xref #20168
/xref this flake
/cc @openshift/sig-network-edge
/cc @smarterclayton