Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize ingressip controller unit test #20352

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Stabilize ingressip controller unit test #20352

merged 1 commit into from
Jul 18, 2018

Commits on Jul 18, 2018

  1. Stabilize ingressip controller unit test 

    Eliminate flakes in the TestBasicControllerFlow test by polling fake action
state rather than relying on custom fake watch consumption; the event counts on
the watch are not deterministic, and so the previous assumption of two events
doesn't always hold and causes a deadlock in the test's custom controller
handler.

Refactor the test to remove unnecessary fake watch and controller setup; just
use the fake client and its built-in watch capabilities directly.
    @ironcladlou
    ironcladlou committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    0179284 View commit details
    Browse the repository at this point in the history