Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile images/pod with linux target only #896

Closed
wants to merge 1 commit into from
Closed

Compile images/pod with linux target only #896

wants to merge 1 commit into from

Conversation

ironcladlou
Copy link
Contributor

Add the linux tag to the images/pod build to ensure no attempt is
made to compile it for unsupported (non-linux) platforms. This fixes
native build-images.sh builds on OSX.

@ironcladlou
Compile images/pod with linux target only
41d60a2 
Add the linux tag to the images/pod build to ensure no attempt is
made to compile it for unsupported (non-linux) platforms. This fixes
native build-images.sh builds on OSX.
@ironcladlou
Copy link
Contributor Author

@smarterclayton This quickly solves the problem of native OSX builds.

@ironcladlou
Copy link
Contributor Author

Actually, hang on. Something's not right here.

@ironcladlou
Copy link
Contributor Author

I forgot to actually change the arch. :)

@ironcladlou
Copy link
Contributor Author

Nevermind- cross compiling could potentially require client installation changes (e.g. make.bash).

@ironcladlou ironcladlou closed this Feb 5, 2015
@smarterclayton
Copy link
Contributor

I thought you had to compile with GOOS to get it to cross compile? Didn't know -tags worked

@ironcladlou
Copy link
Contributor Author

You're right, you do need GOOS, but then your go installation has to have cross-compilation bootstrapped, and so that would impose requirements on the user and probably break most people.

jpeeler added a commit to jpeeler/origin that referenced this pull request Jun 15, 2017
@jpeeler
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
1836b6f 
…service-catalog/' changes from c91fecb..1bfff53

1bfff53 instance never provisioned should just delete (openshift#891)
1ae26db Adding a fake broker server (openshift#928)
6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931)
8ac0775 Merge branch 'pr/927'
02af952 Merge branch 'pr/876'
2aa84f9 add Jenkins badge to README
0c08788 Brokers must have at least one service (openshift#930)
cbfa39b Add PodPreset support (openshift#917)
0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916)
066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877)
203af5c Add leader election namespace configuration (openshift#920)
5831502 Add example JSON schema to controller unit tests (openshift#918)
b78ab99 Fix usage of finalizers (openshift#894)
d3d29f0 Enable pprof in controller-manager (openshift#896)
f4233a0 Correct parameter schema support (openshift#912)
05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910)
97d278a Add support for OSB parameter schemas (openshift#822)
3e4120e Fix nil dereference panic on request timeout (openshift#906)
d8c7494 Add feature gate for audit options in helm chart (openshift#904)
89ce1cd Decompose controller unit tests (openshift#899)
a1e83b2 Add e2e for walkthrough (openshift#832)
4679685 Add support for audit log options (openshift#897)
262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853)
7295dad Validate that a ServiceClass must have at least one plan (openshift#879)
9db9fa4 Decompose controller.go (openshift#893)
c3ea9bd Nits in our types (openshift#854)
1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892)
5e6925d Clean up the OSB client (openshift#888)
fe6aee9 cleaning up logs and adding more log detail (openshift#874)
f41516f Detect if a TPR update represents a soft delete (openshift#836)
9ce99f3 Add functions on Makefile for build and tag
REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build
REVERT: 55ccf3d origin build: add _output to .gitignore
REVERT: 8352e14 origin build: make build-go and build-cross work
REVERT: d969641 origin build: modify hard coded path
REVERT: 30000cc origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 1bfff53
jpeeler added a commit to jpeeler/origin that referenced this pull request Jun 15, 2017
@jpeeler
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
69f2840 
…service-catalog/' changes from c91fecb..568a7b9

568a7b9 origin build: add origin tooling
1bfff53 instance never provisioned should just delete (openshift#891)
1ae26db Adding a fake broker server (openshift#928)
6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931)
8ac0775 Merge branch 'pr/927'
02af952 Merge branch 'pr/876'
2aa84f9 add Jenkins badge to README
0c08788 Brokers must have at least one service (openshift#930)
cbfa39b Add PodPreset support (openshift#917)
0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916)
066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877)
203af5c Add leader election namespace configuration (openshift#920)
5831502 Add example JSON schema to controller unit tests (openshift#918)
b78ab99 Fix usage of finalizers (openshift#894)
d3d29f0 Enable pprof in controller-manager (openshift#896)
f4233a0 Correct parameter schema support (openshift#912)
05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910)
97d278a Add support for OSB parameter schemas (openshift#822)
3e4120e Fix nil dereference panic on request timeout (openshift#906)
d8c7494 Add feature gate for audit options in helm chart (openshift#904)
89ce1cd Decompose controller unit tests (openshift#899)
a1e83b2 Add e2e for walkthrough (openshift#832)
4679685 Add support for audit log options (openshift#897)
262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853)
7295dad Validate that a ServiceClass must have at least one plan (openshift#879)
9db9fa4 Decompose controller.go (openshift#893)
c3ea9bd Nits in our types (openshift#854)
1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892)
5e6925d Clean up the OSB client (openshift#888)
fe6aee9 cleaning up logs and adding more log detail (openshift#874)
f41516f Detect if a TPR update represents a soft delete (openshift#836)
9ce99f3 Add functions on Makefile for build and tag
REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build
REVERT: 55ccf3d origin build: add _output to .gitignore
REVERT: 8352e14 origin build: make build-go and build-cross work
REVERT: d969641 origin build: modify hard coded path
REVERT: 30000cc origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
sjenning pushed a commit to sjenning/origin that referenced this pull request Jan 5, 2018
@bparees
Merge pull request openshift#896 from miminar/prune-retry-on-conflict…
ced9574 
…-3.5

Retry image stream updates when pruning images
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@derekwaynecarr @arschles
Enable pprof in controller-manager (openshift#896)
d3d29f0 
* Enable pprof in controller-manager

* Expose profiling options in chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ironcladlou @smarterclayton