-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1189390 - fix project selector so it gets re-rendered after project list changes #918
Bug 1189390 - fix project selector so it gets re-rendered after project list changes #918
Conversation
1378650
to
da774e9
Compare
@liggitt review |
}); | ||
}); | ||
var select = $('.selectpicker', element); | ||
$each($scope.projects, function(name, project) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make this a function we can call on load and on $scope.projects update
LGTM after comments are addressed |
da774e9
to
0199374
Compare
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/848/) (Image: devenv-fedora_723) |
[Test]ing while waiting on the merge queue |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1005/) |
unrelated [merge] |
Evaluated for origin up to 0199374 |
…service-catalog/' changes from c91fecb..1bfff53 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 1bfff53
…service-catalog/' changes from c91fecb..568a7b9 568a7b9 origin build: add origin tooling 1bfff53 instance never provisioned should just delete (openshift#891) 1ae26db Adding a fake broker server (openshift#928) 6403076 docs: fix quoting issue, clarify naming in auth.md (openshift#931) 8ac0775 Merge branch 'pr/927' 02af952 Merge branch 'pr/876' 2aa84f9 add Jenkins badge to README 0c08788 Brokers must have at least one service (openshift#930) cbfa39b Add PodPreset support (openshift#917) 0d9b810 refactor Jenkins GitHub status postback to work on non-PR commits (openshift#916) 066159d Converting the AuthSecret field to a union AuthInfo type (openshift#877) 203af5c Add leader election namespace configuration (openshift#920) 5831502 Add example JSON schema to controller unit tests (openshift#918) b78ab99 Fix usage of finalizers (openshift#894) d3d29f0 Enable pprof in controller-manager (openshift#896) f4233a0 Correct parameter schema support (openshift#912) 05c6f00 bump image tags from v0.0.8 to v0.0.9 (openshift#910) 97d278a Add support for OSB parameter schemas (openshift#822) 3e4120e Fix nil dereference panic on request timeout (openshift#906) d8c7494 Add feature gate for audit options in helm chart (openshift#904) 89ce1cd Decompose controller unit tests (openshift#899) a1e83b2 Add e2e for walkthrough (openshift#832) 4679685 Add support for audit log options (openshift#897) 262a94f Do not allow updates to an object if asynchronous operation is in progress (openshift#853) 7295dad Validate that a ServiceClass must have at least one plan (openshift#879) 9db9fa4 Decompose controller.go (openshift#893) c3ea9bd Nits in our types (openshift#854) 1d8280a bump tags from v0.0.7 to v0.0.8 (openshift#892) 5e6925d Clean up the OSB client (openshift#888) fe6aee9 cleaning up logs and adding more log detail (openshift#874) f41516f Detect if a TPR update represents a soft delete (openshift#836) 9ce99f3 Add functions on Makefile for build and tag REVERT: c91fecb Merge pull request openshift#1 from jpeeler/origin-build REVERT: 55ccf3d origin build: add _output to .gitignore REVERT: 8352e14 origin build: make build-go and build-cross work REVERT: d969641 origin build: modify hard coded path REVERT: 30000cc origin build: add origin tooling git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 568a7b9dbdc4fdd1fabffdd52af030ec73124b89
[3.6][Backport] Fix upgrade failure and/or crash on invalid CIDR values in master-config
No description provided.