-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo #1605
[release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo #1605
Conversation
A `fedora-archive.repo` file will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. The `fedora-archive.repo` file in the testing-devel branch will be curled during the container setup instead of the `fedora.repo` file when the version goes EOL. This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release. In this case the version is already EOL, so update the curl command now. This essentially reverts two commits: - 1c1c49b - a0b37f9 [1] coreos/fedora-coreos-config#3128
24c8ed6
to
0497d5b
Compare
/retitle [release-4.16] NO-JIRA: use fedora:38 and fedora-archive.repo |
@marmijo: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle [release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo |
@marmijo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold |
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, marmijo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
81317e1
into
openshift:release-4.16
A
fedora-archive.repo
file will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. Thefedora-archive.repo
file in the testing-devel branch will be curled during the container setup instead of thefedora.repo
file when the version goes EOL.This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release. In this case the version is already EOL, so update the curl command now.
This essentially reverts two commits:
[1] coreos/fedora-coreos-config#3128