Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo #1605

Conversation

marmijo
Copy link
Contributor

@marmijo marmijo commented Sep 4, 2024

A fedora-archive.repo file will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. The fedora-archive.repo file in the testing-devel branch will be curled during the container setup instead of the fedora.repo file when the version goes EOL.

This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release. In this case the version is already EOL, so update the curl command now.

This essentially reverts two commits:

[1] coreos/fedora-coreos-config#3128

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
A `fedora-archive.repo` file will now be used by older branches using
EOL fedora container versions[1]. This now acts as our mechanism for
handling the situation where the EOL Fedora content actually moves to
a different location by pointing to the archived content directly. The
`fedora-archive.repo` file in the testing-devel branch will be curled
during the container setup instead of the `fedora.repo` file when the
version goes EOL.

This does mean we'll still have to maintain this container setup by
updating the curl command as the versions go EOL around each new
release. In this case the version is already EOL, so update the curl
command now.

This essentially reverts two commits:
- 1c1c49b
- a0b37f9

[1] coreos/fedora-coreos-config#3128
@marmijo marmijo force-pushed the 4.16-revert-extensions-releasever branch from 24c8ed6 to 0497d5b Compare September 4, 2024 21:45
@marmijo
Copy link
Contributor Author

marmijo commented Sep 4, 2024

/retitle [release-4.16] NO-JIRA: use fedora:38 and fedora-archive.repo

@openshift-ci openshift-ci bot changed the title [release-4.16] extensions/dockerfile: use fedora:40 to set up container [release-4.16] NO-JIRA: use fedora:38 and fedora-archive.repo Sep 4, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2024
@openshift-ci-robot
Copy link

@marmijo: This pull request explicitly references no jira issue.

In response to this:

A fedora-archive.repo file will now be used by older branches using EOL fedora container versions[1]. This now acts as our mechanism for handling the situation where the EOL Fedora content actually moves to a different location by pointing to the archived content directly. The fedora-archive.repo file in the testing-devel branch will be curled during the container setup instead of the fedora.repo file when the version goes EOL.

This does mean we'll still have to maintain this container setup by updating the curl command as the versions go EOL around each new release. In this case the version is already EOL, so update the curl command now.

This essentially reverts two commits:

[1] coreos/fedora-coreos-config#3128

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@marmijo
Copy link
Contributor Author

marmijo commented Sep 4, 2024

/retitle [release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo

@openshift-ci openshift-ci bot changed the title [release-4.16] NO-JIRA: use fedora:38 and fedora-archive.repo [release-4.16] NO-JIRA: extensions/Dockerfile use fedora:38 and fedora-archive.repo Sep 4, 2024
Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

@marmijo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@marmijo
Copy link
Contributor Author

marmijo commented Sep 5, 2024

/hold
wait to include coreos/fedora-coreos-config#3140

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@marmijo
Copy link
Contributor Author

marmijo commented Sep 6, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@jlebon
Copy link
Member

jlebon commented Sep 6, 2024

/lgtm
/label backport-risk-assessed
/label cherry-pick-approved

@jlebon jlebon added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 6, 2024
@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
Copy link
Contributor

openshift-ci bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81317e1 into openshift:release-4.16 Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants