Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] NO-JIRA: bump fedora-coreos-config #1616

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[release-4.16] NO-JIRA: bump fedora-coreos-config #1616

merged 1 commit into from
Sep 10, 2024

Conversation

marmijo
Copy link
Contributor

@marmijo marmijo commented Sep 9, 2024

This submodule bump is needed to build 4.16 on the ITUP cluster. It should have been part of #1605.

Michael Armijo (3):
      tests/ntp: use the FCOS defined fedora.repo to set up container
      tests/podman/rootless-systemd: use the FCOS defined fedora.repo to set up container
      tests/kola: use fedora-archive.repo when setting up fedora container

xref: coreos/fedora-coreos-config#3140

@marmijo
bump fedora-coreos-config
4c6f1fe 
Michael Armijo (3):
      tests/ntp: use the FCOS defined fedora.repo to set up container
      tests/podman/rootless-systemd: use the FCOS defined fedora.repo to set up container
      tests/kola: use fedora-archive.repo when setting up fedora container
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link

@marmijo: This pull request explicitly references no jira issue.

In response to this:

This submodule bump is needed to build 4.16 on the ITUP cluster. It should have been part of #1605.

Michael Armijo (3):
     tests/ntp: use the FCOS defined fedora.repo to set up container
     tests/podman/rootless-systemd: use the FCOS defined fedora.repo to set up container
     tests/kola: use fedora-archive.repo when setting up fedora container

xref: coreos/fedora-coreos-config#3140

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
aaradhak
aaradhak approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@aaradhak aaradhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@marmijo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dustymabe
dustymabe approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

c4rt0
c4rt0 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaradhak, c4rt0, dustymabe, marmijo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aaradhak,c4rt0,dustymabe,marmijo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon jlebon added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0e17b41 into openshift:release-4.16 Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@c4rt0 c4rt0 c4rt0 approved these changes

@aaradhak aaradhak aaradhak approved these changes

@jmarrero jmarrero Awaiting requested review from jmarrero

@RishabhSaini RishabhSaini Awaiting requested review from RishabhSaini

Assignees

@dustymabe dustymabe

@c4rt0 c4rt0

@aaradhak aaradhak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marmijo @openshift-ci-robot @dustymabe @c4rt0 @aaradhak @jlebon