Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic when checking overrides for LS. #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix logic when checking overrides for LS. #613

wants to merge 1 commit into from
+3 −3

Conversation

bergmannf
Copy link
Contributor

Before this it would print the message when the override were not enabled.

@bergmannf
Fix logic when checking overrides for LS.
0ecce90 
Before this it would print the message when the override were not
enabled.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

@bergmannf: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Tessg22
Copy link
Contributor

Tessg22 commented Sep 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bergmannf, Tessg22
Once this PR has been reviewed and has the lgtm label, please assign devppratik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustman9000 dustman9000 Awaiting requested review from dustman9000

@mjlshen mjlshen Awaiting requested review from mjlshen

Assignees

@Tessg22 Tessg22

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergmannf @Tessg22