Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic when checking overrides for LS. #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Fix logic when checking overrides for LS. #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/cluster/support/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,11 @@ func (o *statusOptions) run() error {
return err
}

var clusterSupportLimited = false
var limitedSupportOverridden = false
table := printer.NewTablePrinter(os.Stdout, 20, 1, 3, ' ')
table.AddRow([]string{"Reason ID", "Summary", "Overridden (SUPPORTEX)", "Details"})
for _, clusterLimitedSupportReason := range clusterLimitedSupportReasons {
clusterSupportLimited = clusterSupportLimited || !clusterLimitedSupportReason.Override().Enabled()
limitedSupportOverridden = limitedSupportOverridden || clusterLimitedSupportReason.Override().Enabled()
table.AddRow([]string{
clusterLimitedSupportReason.ID(),
clusterLimitedSupportReason.Summary(),
Expand All @@ -78,7 +78,7 @@ func (o *statusOptions) run() error {
})
}
// No reasons found, cluster is fully supported
if clusterSupportLimited {
if limitedSupportOverridden {
fmt.Printf("No limited support reasons found or all reasons are overridden, the cluster is fully supported\n")
}
// Add empty row for readability
Expand Down