Update template owners, sync owners files #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
stevekuznetsov
commented
Aug 24, 2018
| @@ -0,0 +1,31 @@ | |||
| filters: | |||
There was a problem hiding this comment.
@smarterclayton FYI
There was a problem hiding this comment.
We may want to roll this back, because the approve plugin currently doesn't work with filters (kubernetes/test-infra#7690).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 27, 2018
This will make it easier to add special-case OWNERS files to openshift/release while still getting the members slurped up with the populate-owners.sh script from openshift/release@79e1e6ea (Sync OWNERS, 2018-08-24, openshift/release#1279). We'll have to teach that script about OWNERS_ALIASES, but at least we won't have to copy/paste the approver/review members over into the release repo manually.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 30, 2018
This will make it easier to add special-case OWNERS files to openshift/release while still getting the members slurped up with the populate-owners.sh script from openshift/release@79e1e6ea (Sync OWNERS, 2018-08-24, openshift/release#1279). We'll have to teach that script about OWNERS_ALIASES, but at least we won't have to copy/paste the approver/review members over into the release repo manually.
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Aug 30, 2018
This reverts commit a3e9a3f (openshift#1279). Using filters for approvers and reviewers is the long-term goal, but the approve plugin can't handle this yet [1,2]. [1]: kubernetes/test-infra#7690 [2]: https://github.com/kubernetes/community/blame/19dc4bed5b05c23a69e631f96573f8ed2e0774cb/contributors/guide/owners.md#L86-L87
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Add default definition for RHCOS_LIVE_IMAGES in common.sh
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
* Revert "Add support for Live CoreOS URLS (openshift#1279)" We no longer need to mirror these images, because they're supplied by machine-os-images in the release payload. This reverts commit 53e4b2e. * Don't pass clusterOSImage in install-config for 4.10+ We no longer need to pass a QCOW to the installer for the cluster OS (we still need it for the bootstrap), so don't do it any more starting with 4.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.