Skip to content

Commit

Permalink
OWNERS_ALIASES: Define aliases for reviewers and approvers
Browse files Browse the repository at this point in the history
This will make it easier to add special-case OWNERS files to
openshift/release while still getting the members slurped up with the
populate-owners.sh script from openshift/release@79e1e6ea (Sync
OWNERS, 2018-08-24, openshift/release#1279).  We'll have to teach that
script about OWNERS_ALIASES, but at least we won't have to copy/paste
the approver/review members over into the release repo manually.
  • Loading branch information
wking committed Aug 30, 2018
1 parent f941341 commit 25dcad7
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Before creating your PR, please make sure to add the appropriate GitHub label; i.e. `run-smoke-tests`. For more details see
[tests/README.md](../tests/README.md).

(In case you don't have permissions to add labels, please ask a [maintainer](../OWNERS).)
(In case you don't have permissions to add labels, please ask [a](../OWNERS) [maintainer](../OWNERS_ALIASES).)
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ For contributors who want to work up pull requests, the workflow is roughly:
```
Note that a portion of the docs and examples are generated and that the generated files are to be committed by you. `make structure-check` checks that what is generated is what you must commit.
7. Submit a pull request to the original repository.
8. The [repo owners](OWNERS) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].
8. The [repo](OWNERS) [owners](OWNERS_ALIASES) will respond to your issue promptly, following [the ususal Prow workflow][prow-review].

Thanks for your contributions!

Expand Down
10 changes: 3 additions & 7 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md
# This file just uses aliases defined in OWNERS_ALIASES.

approvers:
- aaronlevy
- abhinavdahiya
- crawford
- smarterclayton
- wking
- yifan-gu
- installer-approvers
reviewers:
- vikramsk
- installer-reviewers
12 changes: 12 additions & 0 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES

aliases:
installer-approvers:
- aaronlevy
- abhinavdahiya
- crawford
- smarterclayton
- wking
- yifan-gu
installer-reviewers:
- vikramsk
2 changes: 1 addition & 1 deletion tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ In addition to our basic set of tests we have smoke tests which are running on A
### FAQ
- *I am not able to add labels, what should I do?*

Please ask one of [the repository maintainers](../OWNERS) to add the
Please ask one of the [repository](../OWNERS) [maintainers](../OWNERS_ALIASES) to add the
labels.

- *How do I retrigger the tests?*
Expand Down

0 comments on commit 25dcad7

Please sign in to comment.