forked from openshift/installer
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
OWNERS_ALIASES: Define aliases for reviewers and approvers
This will make it easier to add special-case OWNERS files to openshift/release while still getting the members slurped up with the populate-owners.sh script from openshift/release@79e1e6ea (Sync OWNERS, 2018-08-24, openshift/release#1279). We'll have to teach that script about OWNERS_ALIASES, but at least we won't have to copy/paste the approver/review members over into the release repo manually.
- Loading branch information
Showing
5 changed files
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Before creating your PR, please make sure to add the appropriate GitHub label; i.e. `run-smoke-tests`. For more details see | ||
[tests/README.md](../tests/README.md). | ||
|
||
(In case you don't have permissions to add labels, please ask a [maintainer](../OWNERS).) | ||
(In case you don't have permissions to add labels, please ask [a](../OWNERS) [maintainer](../OWNERS_ALIASES).) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,7 @@ | ||
# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md | ||
# This file just uses aliases defined in OWNERS_ALIASES. | ||
|
||
approvers: | ||
- aaronlevy | ||
- abhinavdahiya | ||
- crawford | ||
- smarterclayton | ||
- wking | ||
- yifan-gu | ||
- installer-approvers | ||
reviewers: | ||
- vikramsk | ||
- installer-reviewers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#OWNERS_ALIASES | ||
|
||
aliases: | ||
installer-approvers: | ||
- aaronlevy | ||
- abhinavdahiya | ||
- crawford | ||
- smarterclayton | ||
- wking | ||
- yifan-gu | ||
installer-reviewers: | ||
- vikramsk |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters