Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Drop cluster-launch-installer-e2e-smoke references #1768

Merged
merged 1 commit into from
Oct 2, 2018
Merged

*: Drop cluster-launch-installer-e2e-smoke references #1768

merged 1 commit into from
Oct 2, 2018

Conversation

wking
Copy link
Member

@wking wking commented Oct 1, 2018

Like d44e106 (#1755), this is cleaning up after 3f2f01c (#1677).

Spun off from #1761.

@wking
*: Drop cluster-launch-installer-e2e-smoke references
a822b16 
Like d44e106 (remove ref to openshift.yaml aws installer config,
2018-09-27, openshift#1755), this is cleaning up after 3f2f01c
(ci-operator/config/openshift/installer/master: Move to
openshift-install, 2018-09-26, openshift#1677).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 1, 2018
@wking wking mentioned this pull request Oct 1, 2018
Merged
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2018
@bbguimaraes
Copy link
Contributor

@wking: the plan is to reintroduce this template in the future, correct?

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, bbguimaraes, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@openshift-merge-robot openshift-merge-robot merged commit ae97cf2 into openshift:master Oct 2, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the plugins configmap using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml

In response to this:

Like d44e106 (#1755), this is cleaning up after 3f2f01c (#1677).

Spun off from #1761.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Oct 2, 2018

the plan is to reintroduce this template in the future, correct?

Maybe. It's also possible that extending the e2e tests (e.g. #1341) will give us sufficient coverage.

@wking wking deleted the installer-smoke-cleanup branch October 3, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@bbguimaraes bbguimaraes

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wking @abhinavdahiya @bbguimaraes @openshift-ci-robot @openshift-merge-robot