-
Notifications
You must be signed in to change notification settings - Fork 2k
Split API verify targets #42691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split API verify targets #42691
Conversation
|
/pj-rehearse |
|
The rehearsals don't work if you happen to use env vars that prow injects, but, it's working enough for me and I'm confident it will work when it merges |
ef350cb to
242cfa3
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
This depends on openshift/api#1568
The intention is that all required verify scripts run under
verifyand those that are sometimes optional, are separate.The CRD schema checker may sometimes fail on false positives, for example, if you introduce a TechPreview version of a pre-existing CRD, or if you copy/paste an existing supported API from elsewhere.
To make it easier to distinguish the failures, keep this as a separate target.