Skip to content

Conversation

@JoelSpeed
Copy link
Contributor

This depends on openshift/api#1568

The intention is that all required verify scripts run under verify and those that are sometimes optional, are separate.

The CRD schema checker may sometimes fail on false positives, for example, if you introduce a TechPreview version of a pre-existing CRD, or if you copy/paste an existing supported API from elsewhere.

To make it easier to distinguish the failures, keep this as a separate target.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@JoelSpeed
Copy link
Contributor Author

/pj-rehearse

@JoelSpeed
Copy link
Contributor Author

The rehearsals don't work if you happen to use env vars that prow injects, but, it's working enough for me and I'm confident it will work when it merges
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 25, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 30, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@JoelSpeed: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-verify-crd-schema openshift/api presubmit Presubmit changed
pull-ci-openshift-api-release-4.14-verify-crd-schema openshift/api presubmit Presubmit changed
pull-ci-openshift-api-release-4.15-verify-crd-schema openshift/api presubmit Presubmit changed
pull-ci-openshift-api-release-4.15-verify openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-master-verify openshift/api presubmit Ci-operator config changed
pull-ci-openshift-api-release-4.14-verify openshift/api presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/api/release-4.15/verify-crd-schema ef350cb927dacb56712af0fe15eaae7b183fa21e link unknown /pj-rehearse pull-ci-openshift-api-release-4.15-verify-crd-schema
ci/rehearse/openshift/api/release-4.14/verify-crd-schema ef350cb927dacb56712af0fe15eaae7b183fa21e link unknown /pj-rehearse pull-ci-openshift-api-release-4.14-verify-crd-schema
ci/rehearse/openshift/api/master/verify-crd-schema ef350cb927dacb56712af0fe15eaae7b183fa21e link unknown /pj-rehearse pull-ci-openshift-api-master-verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoelSpeed
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 378041d into openshift:master Aug 31, 2023
dtthuynh pushed a commit to dtthuynh/release that referenced this pull request Sep 1, 2023
prb112 pushed a commit to prb112/openshift-release that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants