Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-844] Migrate to kubebuilder go/v4 #52925

Merged

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Jun 7, 2024

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 57b0444 to 45d5092 Compare June 13, 2024 07:36
@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jun 13, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@bouskaJ: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 45d5092 to 228a825 Compare June 13, 2024 08:06
@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jun 13, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@bouskaJ: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 228a825 to 009874a Compare June 13, 2024 08:36
@bouskaJ
Copy link
Contributor Author

bouskaJ commented Jun 13, 2024

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@bouskaJ: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bouskaJ: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-securesign-secure-sign-operator-main-tas-operator-e2e securesign/secure-sign-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 13, 2024
@osmman
Copy link
Contributor

osmman commented Jun 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ, osmman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@bouskaJ: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit f70bb6c into openshift:master Jun 13, 2024
16 checks passed
lihongyan1 pushed a commit to lihongyan1/release that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants