Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-844] Migrate to kubebuilder go/v4 #431

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

bouskaJ
Copy link
Collaborator

@bouskaJ bouskaJ commented Jun 6, 2024

No description provided.

@bouskaJ bouskaJ requested review from osmman, tommyd450 and JasonPowr June 6, 2024 12:46
@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from b9acc01 to 92b0989 Compare June 6, 2024 12:48
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bouskaJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@bouskaJ bouskaJ marked this pull request as draft June 6, 2024 12:52
@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch 9 times, most recently from 18da90a to 2f9174e Compare June 6, 2024 13:25
@bouskaJ bouskaJ marked this pull request as ready for review June 6, 2024 13:27
@openshift-ci openshift-ci bot requested review from lkatalin and sallyom June 6, 2024 13:27
@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch 2 times, most recently from caa053d to 01d743b Compare June 6, 2024 13:35
@bouskaJ bouskaJ marked this pull request as draft June 6, 2024 14:04
@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 01d743b to 06fade2 Compare June 7, 2024 06:50
@bouskaJ bouskaJ marked this pull request as ready for review June 7, 2024 07:22
@openshift-ci openshift-ci bot requested a review from sabre1041 June 7, 2024 07:22
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jun 7, 2024

in order to pass tas-operator-e2e openshift/release#52925 needs to be merged

.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
bundle/manifests/rhtas.redhat.com_ctlogs.yaml Outdated Show resolved Hide resolved
bundle.Dockerfile Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@osmman
Copy link
Contributor

osmman commented Jun 11, 2024

.tekton pipelines need to be updated to use new paths. Controller and main.go has been moved so it should test internal, api and cmd folders

event == "push" && target_branch == "main" && (".tekton/rhtas-operator-push.yaml".pathChanged() || "api/***".pathChanged() || "controllers/***".pathChanged() || "Dockerfile.rhtas-operator.rh".pathChanged() || "go.mod".pathChanged() || "go.sum".pathChanged() || "main.go".pathChanged() || "trigger-konflux-builds.txt".pathChanged() )

event == "pull_request" && target_branch == "main" && (".tekton/rhtas-operator-pull-request.yaml".pathChanged() || "api/***".pathChanged() || "controllers/***".pathChanged() || "Dockerfile.rhtas-operator.rh".pathChanged() || "go.mod".pathChanged() || "main.go".pathChanged() || "go.sum".pathChanged() || "trigger-konflux-builds.txt".pathChanged() )

Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate config and bundle resources by controller-gen v0.14.0

@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 3509c41 to 3d66111 Compare June 12, 2024 14:10
@osmman
Copy link
Contributor

osmman commented Jun 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 12, 2024
Copy link

openshift-ci bot commented Jun 12, 2024

@osmman: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • tas-operator-e2e

Only the following failed contexts/checkruns were expected:

  • Test EKS deployment
  • Test kind deployment
  • Upgrade operator test
  • ci/prow/ci-index-securesign-bundle
  • ci/prow/images
  • ci/prow/tas-operator-e2e
  • code/snyk (Application Services - Red Hat Trusted Artifact Signer)
  • pull-ci-securesign-secure-sign-operator-main-ci-index-securesign-bundle
  • pull-ci-securesign-secure-sign-operator-main-images
  • pull-ci-securesign-secure-sign-operator-main-tas-operator-e2e
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@osmman
Copy link
Contributor

osmman commented Jun 12, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Jun 12, 2024

@osmman: Overrode contexts on behalf of osmman: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bouskaJ bouskaJ force-pushed the migrate_kubebuilder_v4 branch from 3d66111 to ac8d234 Compare June 13, 2024 07:04
@openshift-ci openshift-ci bot removed the lgtm label Jun 13, 2024
Copy link

openshift-ci bot commented Jun 13, 2024

New changes are detected. LGTM label has been removed.

@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jun 13, 2024

/override ci/prow/tas-operator-e2e

Copy link

openshift-ci bot commented Jun 13, 2024

@bouskaJ: Overrode contexts on behalf of bouskaJ: ci/prow/tas-operator-e2e

In response to this:

/override ci/prow/tas-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bouskaJ bouskaJ merged commit b7bd354 into main Jun 13, 2024
8 of 11 checks passed
@bouskaJ
Copy link
Collaborator Author

bouskaJ commented Jun 13, 2024

@JasonPowr @tommyd450 File paths changed. Can you check all other components for build.appstudio.openshift.io/build-nudge-files: "internal/controller/constants/*"?

@osmman osmman deleted the migrate_kubebuilder_v4 branch July 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants