Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-13470: update go version for clusterclaims and cluster-curator controller repos #56245

Merged

Conversation

dtthuynh
Copy link
Contributor

@dtthuynh dtthuynh commented Sep 3, 2024

Signed-off-by: David Huynh <dhuynh@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 3, 2024

@dtthuynh: This pull request references ACM-13470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ACM-13470
needed to upgrade hive version in mce 2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 3, 2024

@dtthuynh: This pull request references ACM-13470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ACM-13470
needed to upgrade hive version in mce 2.7

BLOCKING stolostron/clusterclaims-controller#151

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 3, 2024

Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 3, 2024

/assign @xiangjingli

Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh dtthuynh changed the title ACM-13470: update go version for clusterclaims controller ACM-13470: update go version for clusterclaims and cluster-curator controller repos Sep 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 3, 2024

@dtthuynh: This pull request references ACM-13470 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/ACM-13470
needed to upgrade hive version in mce 2.7

BLOCKING
stolostron/clusterclaims-controller#151
stolostron/cluster-curator-controller#266

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: David Huynh <dhuynh@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@dtthuynh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-cluster-curator-controller-main-images stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-main-pr-image-mirror stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-main-sonar stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-main-unit-tests stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-backplane-2.7-images stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-backplane-2.7-pr-image-mirror stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-cluster-curator-controller-backplane-2.7-unit-tests stolostron/cluster-curator-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-backplane-2.7-images stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-backplane-2.7-pr-image-mirror stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-backplane-2.7-unit-tests stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-main-images stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-main-pr-image-mirror stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-main-sonar stolostron/clusterclaims-controller presubmit Ci-operator config changed
pull-ci-stolostron-clusterclaims-controller-main-unit-tests stolostron/clusterclaims-controller presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

@dtthuynh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiangjingli
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 3, 2024
@xiangjingli
Copy link
Contributor

/approve

@xiangjingli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
Copy link
Contributor

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtthuynh, xiangjingli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8e2f74c into openshift:master Sep 3, 2024
15 checks passed
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 4, 2024
…ntroller repos (openshift#56245)

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for controller repos

Signed-off-by: David Huynh <dhuynh@redhat.com>

---------

Signed-off-by: David Huynh <dhuynh@redhat.com>
giladravid16 pushed a commit to giladravid16/release that referenced this pull request Sep 5, 2024
…ntroller repos (openshift#56245)

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for controller repos

Signed-off-by: David Huynh <dhuynh@redhat.com>

---------

Signed-off-by: David Huynh <dhuynh@redhat.com>
MiguelCarpio pushed a commit to MiguelCarpio/release that referenced this pull request Sep 12, 2024
…ntroller repos (openshift#56245)

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for controller repos

Signed-off-by: David Huynh <dhuynh@redhat.com>

---------

Signed-off-by: David Huynh <dhuynh@redhat.com>
obochan-rh pushed a commit to obochan-rh/release that referenced this pull request Sep 24, 2024
…ntroller repos (openshift#56245)

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for clusterclaims controller

Signed-off-by: David Huynh <dhuynh@redhat.com>

* update go version for controller repos

Signed-off-by: David Huynh <dhuynh@redhat.com>

---------

Signed-off-by: David Huynh <dhuynh@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants