-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM-13470: update go version for clusterclaims and cluster-curator controller repos #56245
ACM-13470: update go version for clusterclaims and cluster-curator controller repos #56245
Conversation
Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh: This pull request references ACM-13470 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@dtthuynh: This pull request references ACM-13470 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: David Huynh <dhuynh@redhat.com>
/assign @xiangjingli |
Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh: This pull request references ACM-13470 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: David Huynh <dhuynh@redhat.com>
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@dtthuynh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/pj-rehearse ack |
@xiangjingli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtthuynh, xiangjingli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ntroller repos (openshift#56245) * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for controller repos Signed-off-by: David Huynh <dhuynh@redhat.com> --------- Signed-off-by: David Huynh <dhuynh@redhat.com>
…ntroller repos (openshift#56245) * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for controller repos Signed-off-by: David Huynh <dhuynh@redhat.com> --------- Signed-off-by: David Huynh <dhuynh@redhat.com>
…ntroller repos (openshift#56245) * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for controller repos Signed-off-by: David Huynh <dhuynh@redhat.com> --------- Signed-off-by: David Huynh <dhuynh@redhat.com>
…ntroller repos (openshift#56245) * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for clusterclaims controller Signed-off-by: David Huynh <dhuynh@redhat.com> * update go version for controller repos Signed-off-by: David Huynh <dhuynh@redhat.com> --------- Signed-off-by: David Huynh <dhuynh@redhat.com>
https://issues.redhat.com/browse/ACM-13470
needed to upgrade hive version in mce 2.7
BLOCKING
stolostron/clusterclaims-controller#151
stolostron/cluster-curator-controller#266