Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-13470: upgrade hive in clc repos #266

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

dtthuynh
Copy link
Contributor

@dtthuynh dtthuynh commented Sep 3, 2024

Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 3, 2024

/cc @xiangjingli @fxiang1 @xuezhaojun

@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 3, 2024

blocked by openshift/release#56245

@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 3, 2024

/retest-required

@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 4, 2024

/retest

Signed-off-by: David Huynh <dhuynh@redhat.com>
@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 4, 2024

We need to update the controller-runtime lib in order to work after upgrading the go version. This changes a bit how we call it as well.
refer kubernetes-sigs/controller-runtime#2788

@dtthuynh
Copy link
Contributor Author

dtthuynh commented Sep 4, 2024

/test unit-tests

Signed-off-by: David Huynh <dhuynh@redhat.com>
Copy link

sonarqubecloud bot commented Sep 4, 2024

@fxiang1
Copy link
Contributor

fxiang1 commented Sep 4, 2024

/approve

@openshift-ci openshift-ci bot added the approved label Sep 4, 2024
@fxiang1
Copy link
Contributor

fxiang1 commented Sep 4, 2024

/lgtm

Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtthuynh, fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 93e46c8 into stolostron:main Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants