Implmenet thread-safe mbean collector #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
commented
Nov 25, 2021
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| public Map<Map.Entry<String, Integer>, List<HasBeanObject>> objects() { |
There was a problem hiding this comment.
@wycccccc 這邊的概念就是不管有多少的partitioner，都是共用一個BeanCollector，並且跟BeanCollector索取對應的server:port metrics。換言之，不管是要拿metrics來算分、排序或是做任何事情，他們都不需要再去直接面對MBeanClient。
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
這是用來示範如何將partitioner中最需要統一管理（因為效能和連線數的考量）的mbean集中化