Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance ReplicaCollie to support migrate replica to another folder #133

Merged
merged 27 commits into from
Jan 29, 2022
Merged

Enhance ReplicaCollie to support migrate replica to another folder #133

merged 27 commits into from
Jan 29, 2022

Conversation

qoo332001
Copy link
Collaborator

@qoo332001 qoo332001 commented Nov 30, 2021 •
edited
Loading

這支PR在ReplicaCollie內增加了可以在同一個broker內搬移多個partition，以及指定搬移路徑的功能（#123）

chia7712
chia7712 reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝patch 幾個建議請看一下 謝謝

README.md Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
@qoo332001
Copy link
Collaborator Author

上述問題皆已處理

@qoo332001 qoo332001 requested a review from chia7712 December 8, 2021 13:40
chia7712
chia7712 reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qoo332001 感謝更新，幾個設計建議還請看一下

app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
app/src/main/java/org/astraea/topic/ReplicaCollie.java Outdated Show resolved Hide resolved
@qoo332001 qoo332001 requested a review from chia7712 December 27, 2021 16:54
@qoo332001 qoo332001 requested a review from chia7712 January 10, 2022 23:17
@qoo332001 qoo332001 requested a review from chia7712 January 23, 2022 13:50
@chia7712
Copy link
Contributor

@qoo332001 please rebase code

@chia7712 chia7712 merged commit 82cc3ed into opensource4you:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qoo332001 @chia7712