Score on partition #303
Merged
Score on partition #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Apr 14, 2022
chia7712
reviewed
Apr 15, 2022
|
這裡新增介面， 包含4種建立方法，
|
chia7712
reviewed
Apr 15, 2022
chia7712
reviewed
Apr 15, 2022
chia7712
reviewed
Apr 15, 2022
Move `leaderOf` to PartitionInfo and rename. Remove unused method.
|
@chia7712 可以麻煩您再review一次PR嘛？感謝您。 |
chia7712
reviewed
Apr 15, 2022
chia7712
reviewed
Apr 15, 2022
chia7712
reviewed
Apr 16, 2022
chia7712
reviewed
Apr 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如#289 (comment)
需要對partition進行打分。更甚者，包括replica也要打分。
更改CostFunction的回傳值，CostFunction將會對
org.apache.kafka.common.TopicPartitionReplica做打分。原本有許多cost function都是以broker進行打分的，目前我不做更動，只有讓它們符合現在的介面，本質仍然是對broker打分，以後也許可以做更精準的打分(對partition打分)。
另外，在進行修改的過程中發現，partitioner 會希望 cost function 知道發送到哪個 topic，之後要討論"新增topic 到cost function 參數中"。