-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Four new cost functions #306
Conversation
@chia7712 按照新的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wycccccc 這次的PR整齊目的又明確,讚讚
兩個建議請看一下
app/src/main/java/org/astraea/cost/brokersMetrics/BrokerInputCost.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wycccccc 有那個樣子了,不過犯了一個語法錯誤,請看一下
app/src/main/java/org/astraea/cost/brokersMetrics/memoryCost.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/cost/brokersMetrics/BrokerInputCost.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wycccccc 還有一些想法,請參考
app/src/main/java/org/astraea/cost/brokersMetrics/CostUtils.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/cost/brokersMetrics/CostUtils.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/cost/brokersMetrics/BrokerInputCost.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/cost/brokersMetrics/BrokerOutputCost.java
Outdated
Show resolved
Hide resolved
@chia7712 上述conversation已被解決,再麻煩學長review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wycccccc 感謝更新,大部分看起來不錯。有一個比較大的設計問題在底下,看看大家的想法
app/src/test/java/org/astraea/cost/brokersMetrics/memoryCostTest.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/astraea/cost/brokersMetrics/BrokerOutputCost.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wycccccc 這次的主題明確、程式碼也很乾淨俐落!
補完測試後就可以合併了,謝謝
完成 #298 第一階段
它們大致會長這樣
等待 #303 合併後解決 costFunctions conflict