Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise ClusterLogAllocation #764

Merged

Conversation

garyparrot
Copy link
Collaborator

  • 編修 ClusterLogAllocation 的 javadoc
  • 重寫 ClusterLogAllocation 的測試,提升 readability & coverage
  • 修正 ClusterLogAllocation#letReplicaBecomeLeader 的小問題
    • 執行後 replica 和對應 leader 的 replica 資訊會錯亂
  • 重新命名 ClusterLogAllocation#letReplicaBecomeLeaderClusterLogAllocation#becomeLeader

@garyparrot garyparrot self-assigned this Sep 26, 2022
chia7712
chia7712 previously approved these changes Sep 26, 2022
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這次做得很好,只有兩個跟這隻 PR 沒直接相關的建議,謝謝

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@garyparrot garyparrot merged commit bc85132 into opensource4you:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants