Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events to Bills: Add -1 Day to Match Query #141

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Conversation

NewAgeAirbender
Copy link
Contributor

If an Event is scheduled for the last day of a session, we'd miss the match to a bill because the start_date of the Event is the same as the date the Legislative session ended. I've verified that this catches & actually matches Events with Bills that are on the last day of the session with AK, this would also capture Bills added to events that take place just before session start if there are discussions on prefiled bills.

openstates/importers/base.py Outdated Show resolved Hide resolved
openstates/importers/base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@alexobaseki alexobaseki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one concern/ question.

openstates/importers/base.py Outdated Show resolved Hide resolved
openstates/importers/base.py Outdated Show resolved Hide resolved
openstates/importers/base.py Outdated Show resolved Hide resolved
@NewAgeAirbender NewAgeAirbender changed the title Events to Bills: Add -4 Day Retry Events to Bills: Add -1 Day Retry Sep 13, 2024
@NewAgeAirbender NewAgeAirbender changed the title Events to Bills: Add -1 Day Retry Events to Bills: Add -1 Day to Match Query Sep 13, 2024
@NewAgeAirbender
Copy link
Contributor Author

Update: Dropped it to a single day in the first query so we don't have to delay a lot. I think there still may be a case for retrying with a larger date range for jurisdictions without special sessions, but we can get to that later.

@NewAgeAirbender NewAgeAirbender merged commit 6c7cb58 into main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants