Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events to Bills: Add -1 Day to Match Query #141

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Events to Bills: Add -1 Day to Match Query #141

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fdb5c13
Resolve Bills: init retry query
NewAgeAirbender Sep 10, 2024
4375d71
Events: retry working & updated logs
NewAgeAirbender Sep 12, 2024
e58cf6f
Resolve Bills: tweak initial query, retry a week
NewAgeAirbender Sep 12, 2024
d4fd0c8
Resolve Bill: update test to correct event start_date format
NewAgeAirbender Sep 12, 2024
dacf285
Resolve Bills: just change date for initial query
NewAgeAirbender Sep 13, 2024
d2c6da6
Resolve Organizations: add iexact to make incasesensitive
NewAgeAirbender Sep 13, 2024
d6c2684
Resolve Organizations: restore previous query
NewAgeAirbender Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion openstates/importers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import json
import logging
import typing
from datetime import datetime, timedelta
from django.db.models import Q, Model
from django.db.models.signals import post_save
from .. import settings
Expand Down Expand Up @@ -180,7 +181,24 @@ def resolve_bill(self, bill_id: str, *, date: str) -> typing.Optional[_ID]:
if len(ids) == 1:
return ids.pop()
elif len(ids) == 0:
NewAgeAirbender marked this conversation as resolved.
Show resolved Hide resolved
self.error(f"could not resolve bill id {bill_id} {date}, no matches")
self.warning(f"could not resolve bill id {bill_id} {date}, no matches so will retry")
date = datetime.fromisoformat(date)
new_date = date + timedelta(days=-4)
NewAgeAirbender marked this conversation as resolved.
Show resolved Hide resolved
objects = Bill.objects.filter(
Q(legislative_session__end_date__gte=new_date)
| Q(legislative_session__end_date=""),
legislative_session__start_date__lte=new_date,
legislative_session__jurisdiction_id=self.jurisdiction_id,
identifier=bill_id,
)
ids = {each.id for each in objects}
if len(ids) == 1:
self.info(f"resolved bill id {bill_id} with tweaked start_date {new_date}")
return ids.pop()
else:
self.error(
f"could not resolve bill with tweaked date {bill_id} {new_date}, {len(ids)} matches"
)
else:
self.error(
f"could not resolve bill id {bill_id} {date}, {len(ids)} matches"
Expand Down
Loading