Core 597 include Spanish titles in renewal form #2797
Conversation
There was a problem hiding this comment.
This is the change that makes the Spanish books show up.
There was a problem hiding this comment.
I had lost some test coverage and noticed that I assigned to href instead of calling assign() (which is more recommended).
There was a problem hiding this comment.
This made them more succinct and also made the typing work better (fewer casts)
There was a problem hiding this comment.
The adoption form uses similar code; the big thing was getting the language in the data.
There was a problem hiding this comment.
Updated all-books to include Spanish titles; also made a better pattern for isBookTitles because it confused me about which data the test was using.
There was a problem hiding this comment.
Had an untested branch and fixed up some noisy output while I was in.
RoyEJohnson
force-pushed
the
core-597-include-spanish-titles-in-renewal-form
branch
from
fa8fc87 to
240e431
Compare
CORE-597