Merge pull request #1188 from user202729/fix-leak-suggestions

Fix unbounded memory use caused by defaultdict access in suggestions feature
openstenoproject · Apr 1, 2021 · 5f236ba · 5f236ba
2 parents 1a667b1 + b7b0aee
commit 5f236ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/news.d/bugfix/1188.core.md b/news.d/bugfix/1188.core.md
@@ -0,0 +1 @@
+Fix unbounded memory use in the lookup functions used by the Suggestions window.
diff --git a/plover/steno_dictionary.py b/plover/steno_dictionary.py
@@ -157,10 +157,10 @@ def __contains__(self, key):
         return self.get(key) is not None
 
     def reverse_lookup(self, value):
-        return set(self.reverse[value])
+        return set(self.reverse.get(value, ()))
 
     def casereverse_lookup(self, value):
-        return set(self.casereverse[value])
+        return set(self.casereverse.get(value, ()))
 
     @property
     def _longest_key(self):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix unbounded memory use in the lookup functions used by the Suggestions window.