Fix memory leak caused by defaultdict access in suggestions feature #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morinted
approved these changes
Apr 1, 2021
|
Nice catch, technically not a memory leak, but a case of unbounded memory use when using the suggestions. Can you add a news entry? |
|
I've added a news fragment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes a memory leak in the suggestions feature.
The leak only become apparent to me when I use the new console GUI. (normally I never use the suggestions window)
Remark: when I use the console GUI, I occasionally get a hang too. I guess it's caused by either dict rehash or garbage collection.
Pull Request Checklist