Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes can't select existing features #1676

Closed
aawiseman opened this issue Aug 8, 2013 · 40 comments
Closed

Sometimes can't select existing features #1676

aawiseman opened this issue Aug 8, 2013 · 40 comments
Labels
bug-browser-specific A bug that only appears in certain browsers

Comments

@aawiseman
Copy link

Sometimes when I want to select an existing feature, it won't let me. Instead when I click it moves the feature a little bit. It seems to do it for points, lines and areas. If I refresh my browser it will work for the first feature, then go back to just moving it and not selecting it.

I'm using Chrome on a PC.

@Stalfur
Copy link
Contributor

Stalfur commented Aug 10, 2013

Same thing has happened to me since iD was released in the beginning. I've usually solved it by clicking on the buttons above, selecting Area for example and then deselect it and then cursor behaves normally for a while.

Chrome on PC as well.

@aawiseman
Copy link
Author

I tried that, it doesn't seem to help though.

@jfirebaugh
Copy link
Member

Does this coincide with symptoms like in #1678?

@jfirebaugh
Copy link
Member

Also, are there any errors in the JavaScript console (Ctrl-Shift-J) when this happens?

@aawiseman
Copy link
Author

No, it doesn't seem like #1678 . Will check on the second one.

@aawiseman
Copy link
Author

I haven't been able to replicate it, but if I do I'll post it here.

@pauliuszaleckas
Copy link

I have similar problem with Firefox on Linux.
After some editing I can't select any ways anymore.

@pauliuszaleckas
Copy link

Errors from FF console:
TypeError: property "iD_http://www.openstreetmap.org_saved_history" is non-configurable and can't be deleted
TypeError: o is undefined

Is there a way to use not minimized version of iD?
Then I could tell specific line where errors happened.

@jfirebaugh
Copy link
Member

Yeah, can you try on http://openstreetmap.us/iD/release/? Thanks!

On Aug 16, 2013, at 7:45 AM, Paulius Zaleckas notifications@github.com wrote:

Errors from FF console:
TypeError: property "iD_http://www.openstreetmap.org_saved_history" is non-configurable and can't be deleted
TypeError: o is undefined

Is there a way to use not minimized version of iD?
Then I could tell specific line where errors happened.


Reply to this email directly or view it on GitHub.

@Stalfur
Copy link
Contributor

Stalfur commented Aug 16, 2013

Testing on @jfirebaugh link I can replicate the behavior by double-clicking quickly on a Point element, it then locks that element in place and I can no longer pick any element, Point, points in Areas or other. Clicking on an element in the menu (Point,Line,Area) and then click on it again to deselect gets me able to move around.
The JavaScript console meanwhile doesn't mention anything on Chrome.

@jfirebaugh
Copy link
Member

@Stalfur Very strange, I can't reproduce that on Chrome 28 either on Mac or on PC. Double-clicking a point zooms in one level and selects the point without any ill effects. Can you try the same thing in an incognito window?

@Stalfur
Copy link
Contributor

Stalfur commented Aug 17, 2013

Tried in incognito, I am still able to double-click so that I can't select any feature. This time it took 4 attempts (zoomed in the first tries) but it happened both while logged in and also in an incognito window, and I'm not getting anything in javascript console on Chrome.

@pauliuszaleckas
Copy link

On another PC I tried editing and everything was OK with FF 22, but when I installed FF 23 it is almost impossible to use iD. Now I get the same error:
TypeError: property "iD_http://openstreetmap.us_saved_history" is non-configurable and can't be deleted
else if (v === null) delete storage[k];
iD.js (line 15035)

@jfirebaugh
Copy link
Member

@pauliuszaleckas I believe the FF issue to have a different cause, and I'm fairly confident I have a fix for 1.1.4.

I'm stumped on the Chrome issue.

@pauliuszaleckas
Copy link

Yes, 1.1.4 works OK with FF. Thank you.

@Stalfur
Copy link
Contributor

Stalfur commented Sep 26, 2013

Video showing behavior http://www.youtube.com/watch?v=IlFbrDPB-M0

@pnorman
Copy link
Contributor

pnorman commented Sep 26, 2013

I did some debugging with @jfirebaugh and this issue can be reproduced on latest master by dragging a node then double-clicking that node. It does not occur if you pan the map before doing those actions and having saved data then resetting that data does not matter. Chrome 29.0.1547.76 (Official Build 223446) m on Windows 7 SP 1

@jfirebaugh
Copy link
Member

From the debugging session we determined that when this happens, iD is stuck in the DragNode mode (determined by evaluating id.mode() in the JS console). DragNode is entered on mousedown and should be exited on mouseup but for some reason is not.

@jfirebaugh
Copy link
Member

@Stalfur Can you evaluate id.mode() in the JS console when this happens to you and let me know what the output is?

@pnorman
Copy link
Contributor

pnorman commented Sep 27, 2013

I tried on the iMac upstairs and was unable to reproduce in Chrome, so it's specific to Windows + Chrome

@Stalfur
Copy link
Contributor

Stalfur commented Sep 27, 2013

@jfirebaugh I was unable to evaluate it, or get anything at all. It stayed blank the entire time, not seeing any errors or warnings.

@Stalfur
Copy link
Contributor

Stalfur commented Oct 4, 2013

Behavior from video 7 days ago still present in 1.2.1, clicking on a point moves it and locks it.

@jfirebaugh
Copy link
Member

I'm unable to reproduce this with a Win7 + Chrome 30 image in VirtualBox following the steps from this comment.

@pnorman
Copy link
Contributor

pnorman commented Oct 14, 2013

I'm unable to reproduce this with a Win7 + Chrome 30 image in VirtualBox following the steps from this comment.

Nor am I, so it looks like one source of the problem is fixed. Revision 8f0fc43

@jfirebaugh
Copy link
Member

My guess is that Chrome 30 might have fixed a browser bug that was causing this. I'd be surprised if 8f0fc43 is relevant. Is there something that suggests to you that it is?

@pnorman
Copy link
Contributor

pnorman commented Oct 14, 2013

It's relevant because it's the revision on osm.us, not because of any changes in b78e396...8f0fc43

@Stalfur
Copy link
Contributor

Stalfur commented Oct 14, 2013

Testing http://openstreetmap.us/iD/release/ it seems this is fixed by Chrome itself.

@jfirebaugh
Copy link
Member

@aawiseman Is it fixed for you too in Chrome 30?

@jfirebaugh
Copy link
Member

Assuming so, please reopen if not.

@aawiseman
Copy link
Author

I have yet to notice it! So far so good! Thanks.

Andrew

On Wed, Oct 23, 2013 at 4:55 PM, John Firebaugh notifications@github.comwrote:

Assuming so, please reopen if not.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1676#issuecomment-26944710
.

Did you know that 600,000 taxpaying DC residents don't have a vote in
Congress? Support DC Statehood!
http://www.dcvote.org/about/index.cfm

@Stalfur
Copy link
Contributor

Stalfur commented Oct 23, 2013

I've seen this happen very occasionally now, i.e. rarely but does happen.

@jfirebaugh
Copy link
Member

I think 0a3d216 might have fixed the root cause, or one of them anyway.

@bborkmiller
Copy link

FWIW, this happens to me from time to time. Chrome 32.0.1700.76 m on Windows. I'm not sure what I do that makes it start happening. I've tried putting id.mode() in the console, and it replies ReferenceError: id is not defined

@bborkmiller
Copy link

This still happens occasionally. id.mode() seems to indicate that iD is in browse mode. The only thing that will reliably fix the issue and allow me to select ways is to quit Chrome and restart it. And even that can take two or three tries.

@talllguy
Copy link

talllguy commented May 1, 2014

Is this the same issue? #2151

@Stalfur
Copy link
Contributor

Stalfur commented May 1, 2014

Just to verify this does still happen on occasions, not in a manner I can repeat.

@kwiky
Copy link

kwiky commented May 23, 2014

Testing http://openstreetmap.us/iD/release/
NOT FIXED...
Google Chrome Version 34.0.1847.137 m
Windows 7 Pro SP1

@scaidermern
Copy link
Contributor

@jfirebaugh
Copy link
Member

#2151 is the current bug tracking Chrome + Windows issues.

@ro32xx
Copy link

ro32xx commented Jul 25, 2016

Does anyone have a better Chrome fix and/or workaround to below? without suggesting another browser.

Main fix: logoff of OpenStreetMap, close ALL chrome browser windows, launch chrome again, re-logon to OpenStreetMap. Although sometimes i need to do this more than once to fix.

Workaround: hold SHIFT and select one or more objects, hit M then move the selection to new location, hit ENTER to confirm new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-browser-specific A bug that only appears in certain browsers
Projects
None yet
Development

No branches or pull requests

10 participants