Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot edit relations of relations in current master #2469

Closed
xor2k opened this issue Dec 7, 2014 · 1 comment
Closed

Cannot edit relations of relations in current master #2469

xor2k opened this issue Dec 7, 2014 · 1 comment

Comments

@xor2k
Copy link

xor2k commented Dec 7, 2014

How to reproduce (v 1.6.1, master, cloned 2014-12-06):

  1. Add an area, e.g. a simple triangle
  2. Leave it an area (or make it a park or whatever)
  3. Click on the plus below "all relations", then "new relation"
  4. Then, let's say, make the area a boundary. So far, so good.
  5. Then repeat step 3 with that boundary.
  6. What happens: iD switches to "Search Features" mode without any options, see first screenshot below. The newly created relation cannot be edited.

The behavior in the current release branch (1.6.2) is different. Here, relation types are offered, see second screenshot below.

image

image
@bhousel
Copy link
Member

bhousel commented Dec 10, 2014

Good find... Weird things are happening when context.selectedIDs() contains a relation.
I'll check the code for places where we call that function and make sure we handle relations properly.

gmaclennan added a commit to digidem/iD-mapeo that referenced this issue Jun 27, 2016
@gmaclennan
Merge branch 'offline' of github.com:digidem/iD into offline
0c9414c 
* 'offline' of github.com:digidem/iD: (726 commits)
  Add function to change the tile size (zoom value) used for loading tiles from API
  Add substation type field
  Add junction=yes preset
  Add takeaway and delivery fields
  Add levels field to building=commercial
  Add amenity=register_office preset
  Add landuse=garages preset
  Add natural=cave_entrance preset
  Add amenity/fast_food to default suggestions
  Switch to landuse=farmland as the preferred preset (fixes openstreetmap#2478)
  Mode change code in editOff no longer needed.. (because iD.modes.Select listens for drawn event and knows to exit itself)
  Don't exit mode when selected elements are gone until after a draw pass (fixes openstreetmap#2476)
  free radialMenu in exit (fixes openstreetmap#2477)
  handle relation selections, cleanup code, closes openstreetmap#2469, openstreetmap#2470
  Fix help pane button toggling (closes openstreetmap#2471) (and cleanup code to make background, map_data, help panes more consistent)
  Don't pass extra arguments from map to Entity initializer fixes openstreetmap#2465
  Fixed address input while nominatim is not available
  added bench field added bench and covered fields to bus_stop preset
  don't try to call Entity#geometry for midpoints
  Initialize radialMenu earlier This prevents it from being undefined when exiting back to browse mode:   in selectElements() (re 2024e23 crash if element id passed in url hash)   in update() (possible re openstreetmap#2151?)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @xor2k