Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shift-drag selected vertices don't appear #2476

Closed
jfirebaugh opened this issue Dec 14, 2014 · 2 comments
Closed

shift-drag selected vertices don't appear #2476

jfirebaugh opened this issue Dec 14, 2014 · 2 comments

Comments

@jfirebaugh
Copy link
Member

Shift-drag selections of vertices that are normally hidden don't result in those vertices becoming visible. They still appear as selected in the sidebar list, and the radial menu acts on them, they just aren't correctly drawn.

This is a regression and the bisect lands on 2024e23.

@bhousel
Copy link
Member

bhousel commented Dec 15, 2014

Hmm, yeah I think I'll revert 2024e23.
It's the same issue as what we talked about here (selectElements exits select mode because the vertices are not found the DOM).

@bhousel
Copy link
Member

bhousel commented Dec 15, 2014

I think it's ok now -- iD.modes.Select won't exit itself until after receiving a drawn event. This sidesteps all the other tricky issues with the vertices too.

gmaclennan added a commit to digidem/iD-mapeo that referenced this issue Jun 27, 2016
* 'offline' of github.com:digidem/iD: (726 commits)
  Add function to change the tile size (zoom value) used for loading tiles from API
  Add substation type field
  Add junction=yes preset
  Add takeaway and delivery fields
  Add levels field to building=commercial
  Add amenity=register_office preset
  Add landuse=garages preset
  Add natural=cave_entrance preset
  Add amenity/fast_food to default suggestions
  Switch to landuse=farmland as the preferred preset (fixes openstreetmap#2478)
  Mode change code in editOff no longer needed.. (because iD.modes.Select listens for drawn event and knows to exit itself)
  Don't exit mode when selected elements are gone until after a draw pass (fixes openstreetmap#2476)
  free radialMenu in exit (fixes openstreetmap#2477)
  handle relation selections, cleanup code, closes openstreetmap#2469, openstreetmap#2470
  Fix help pane button toggling (closes openstreetmap#2471) (and cleanup code to make background, map_data, help panes more consistent)
  Don't pass extra arguments from map to Entity initializer fixes openstreetmap#2465
  Fixed address input while nominatim is not available
  added bench field added bench and covered fields to bus_stop preset
  don't try to call Entity#geometry for midpoints
  Initialize radialMenu earlier This prevents it from being undefined when exiting back to browse mode:   in selectElements() (re 2024e23 crash if element id passed in url hash)   in update() (possible re openstreetmap#2151?)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants