Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapillary photo overlay can't get disabled #4804

Closed
ghost opened this issue Feb 15, 2018 · 1 comment
Closed

Mapillary photo overlay can't get disabled #4804

ghost opened this issue Feb 15, 2018 · 1 comment
Labels
bug A bug - let's fix this!

Comments

@ghost
Copy link

ghost commented Feb 15, 2018

Hello

After enabling Mapillary photo overlay and later disabling them, the overlay doesn't disappear:

untitled

There is no problem with OpenStreetCam overlay, though.

As this misbehaviour is new, I suspect it has been introduced with the last update of iD.

Browser used: Safari 11.0.3 on macOS 10.12.6
@bhousel bhousel added the bug A bug - let's fix this! label Feb 15, 2018
@fritruc
Copy link

fritruc commented Feb 16, 2018

I found out that this bug was introduced in commit f54d201
If I comment the 4 lines of this commit in master, the bug disapears.
Nonetheless, I don't know how to fix it yet =)

fritruc pushed a commit to fritruc/iD that referenced this issue Feb 16, 2018
fixes openstreetmap#4804: _mlyViewer may be uninitialized
85ae724
bhousel added a commit that referenced this issue Feb 16, 2018
@bhousel
Merge pull request #4809 from fritruc/4804_Mapillary_photo_overlay_ca…
725099e 
…n_t_get_disabled

do not stop mapillary autoplaying if _mlyViewer is not initialized (closes #4804)
@bhousel bhousel mentioned this issue Mar 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @fritruc