do not stop mapillary autoplaying if _mlyViewer is not initialized (closes #4804) #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewer is not initialized
fritruc
force-pushed
the
4804_Mapillary_photo_overlay_can_t_get_disabled
branch
from
85ae724 to
ca493ec
Compare
fritruc
changed the title
fritruc
changed the title
|
Good catch! thanks for the fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't open the image viewer, _mlyViewer is not initialized and when we toggle off the layer, an exception is throw because _mlyViewer is not valid.