-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road Closures #5599
Comments
Sometimes Road Closures are for vehicles only, passing on foot or bike may still be allowed. Could this possibility be included here? |
Probably - I still think we'd show the |
Wouldn't the problem be that Waze has a very quick turn-around for map updates, but OSM can lag many months behind for some providers? As far as I understand, that is one reason to not tag short-term changes, such as road repairs. Plus, Waze users can very easily provide feedback from the app if it's wrong. |
This is really about mapping medium to long term closures (>1 day). I don't think OSM will ever be the best place to map short term closures and other realtime incidents (<1 day). Still, I would like to make OSM as good as it can be. Several companies currently use OSM for navigation and this is a big problem for them. Both: mapping closures, but also removing them when the closure is no longer an issue. |
Yes, that's the part that's still missing from the preset. I want to be able to retain the road classification when toggling a highway in/out of "closed" status.
|
Wouldn't data consumers disallow access for everyone if the road is tagged as under construction? I think access tags would only have an affect if the road is tagged normally? |
OSM does also need to support applications like printing a map on paper or generating a map for a Garmin. Mapping closures shorter than several month seems to be unwanted for this reason.
To allow mapping closure down to e.g. 1 day, we need to invent a method to define a tempory state without altering the long term data.
For the UI: |
A map that doesn't want to show road closures could just style those ways the same as the companion non-closed way. E.g. just render |
The data consumers in this case are engines like OSRM, GraphHopper, Valhalla, yes? |
Yes but if a road is tagged highway=construction then data consumers will ignore the road for routing purposes altogether. Therefore it doesn't matter what access tags you have. So in the scenario where nobody is allowed to access the road, highway=construction is all that is needed. However if you want to still allow some access, you need to keep the road highway=xxx as usual and use the access tags instead. |
This seems like a really silly thing to argue about. |
Sorry if I'm not explaining myself clearly. It was just that you said:
I'm just thinking about foot/bike access tags on a highway=construction way. Data consumers (routing engines) will not take them into account because highway=construction means the road isn't considered for routing. So it's fine if the "Road Closed" preset is shown for a road completely closed, with highway=construction + construction=xxx (+ access=no). But would the "Road Closed" preset be shown for a road with highway=xxx + access=no? |
It's only shown for If users want to add other things like |
@bhousel
Preset name and tag combination mismatch in both directions:
Modifing tags of the road according to the state under construction (e.g. access tags) would make the long-term data unavailable for such applications. Constuction of a new road might last many years. Such applications might not want to render these as an existing road.
I understand the desire, but we need to avoid conflicts with other applications. Otherwise, there wouln't be a consent in the community to map such closures, resulting in lower data quality due to less complete mapping of closures. In addition, we do not only need to support full road closures but also closure of one direction etc.
To simplyfy removing we should invent something which keeps the long-term data unchanged. |
I think that it is strange to add a access tag to a highway under construction. When I map a way under construction, I never add a access key. And if I do, it is to indicate what access restriction the way will have when the construction is ready. To complain a little more, "Road Closed" may not be the best name choice if it is a completely new road that they are building. My suggestion is to remove the requirement for |
This preset isn't for a "Road under construction" OSM don't have a tag specifically for this, but I guess I could invent something different from |
@bhousel You are on a good way, temporarily closing a road is different from (initial) construction. Maybe temporary_closure could be used as as tag/key to express „medium-to-long term closure“. One could add start and end of closure. |
It depends on router. Data consumers are free to allow routing bicycles through |
Do you know if any of most known routers do that? I've just read the OsmAnd's routing profile and they penalize "construction" and "proposed" tags. I support @bhousel proposal. That's the de facto use. For example in Buenos Aires City we have a bridge being demolished to build a new viaduct and the local editors community naturally converted the highway=primary to highway=construction + construction=primary. |
Closing because modelling the accessibility of a road via a preset is not the right approach: OSM uses the In openstreetmap/id-tagging-schema@dd1705e, I've changed the current Closed Road preset into one that matches all A better way to make mappers aware of using the access field for roads that are closed for non-construction reasons would be to leverage the idea of #8904. |
I'd like to leave #2341 open for the general problem of tagging lifecycle changes to roads..
But as a first step, we should make is easy and obvious for users to tag road closures. Road closures significantly impact the navigability of OpenStreetMap.
Waze does a really good job of indicating where a road is closed. I'd like to:
The text was updated successfully, but these errors were encountered: