Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset search bar could show "tips" for certain keywords #8904

Open
tyrasd opened this issue Jan 18, 2022 · 2 comments
Open

Preset search bar could show "tips" for certain keywords #8904

tyrasd opened this issue Jan 18, 2022 · 2 comments
Labels
enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design

Comments

@tyrasd
Copy link
Member

tyrasd commented Jan 18, 2022

There even exist some mapping mistakes which could be alleviated by not offering a preset for certain search keywords in the preset bar, and instead showing a hint message instead. For example (see openstreetmap/id-tagging-schema#354), courtyard matches a preset but most often a courtyard should be mapped as a whole in a building polygon instead. I'm sure there exist more non-features which could be relatively easily catched at that stage as well (pokemon go gyms could be an example).

Somehow related: Currently, iD tries very hard to offer a preset for basically any search term: For example, until recently, the presets didn't include a term for a spillway, but the search still resulted in some unrelated results (see screenshot):

While this is not harmful in most cases, it would be even better to include a generic hint here which could explain that the tagging presets in iD are not exhaustive and perhaps indicate the users to consider the OSM wiki to find the correct tagging.

@tyrasd tyrasd added usability An issue with ease-of-use or design enhancement An enhancement to make an existing feature even better labels Jan 18, 2022
@matkoniecz
Copy link
Contributor

matkoniecz commented Jan 18, 2022

While this is not harmful in most cases, it would be even better to include a generic hint here which could explain that the tagging presets in iD are not exhaustive and perhaps indicate the users to consider the OSM wiki to find the correct tagging.

And this hint would be ranked so it would be below strong matches, right? And appear on top only if nothing really matches?

Maybe even have link to iD tagging preset issue tracker? This may result in a flood of issues and may need to be taken down - but could be good idea. Also openstreetmap/id-tagging-schema#237 (now fixed) is going to be my favorite example of string match going wrong

https://user-images.githubusercontent.com/899988/133435775-037af445-6454-4a1b-b031-f4f35c319e4b.png

tyrasd added a commit to openstreetmap/id-tagging-schema that referenced this issue Jan 18, 2022
this is for now only an intermediate solution until openstreetmap/iD#8904 is implemented
@tyrasd tyrasd mentioned this issue May 12, 2022
3 tasks
@jidanni
Copy link
Contributor

jidanni commented Aug 30, 2023

All I know is I searched
20230830T040727
but didn't find https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcourtyard
so had to enter it manually, upon which
20230830T040535
showed up, and I then saved my edit.

Nowhere in the process did any hint of why things were made intentionally difficult was shown to the user (me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants