Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show validation warnings and errors on the map #5905

Open
quincylvania opened this issue Feb 18, 2019 · 2 comments
Open

Show validation warnings and errors on the map #5905

quincylvania opened this issue Feb 18, 2019 · 2 comments
Labels
map-renderer An issue with how things are rendered in the map validation An issue with the validation or Q/A code

Comments

@quincylvania
Copy link
Collaborator

Post-#5830, native iD issues are listed in a dedicated pane. We should show them on the map as well and have a visibility toggle like we have for KeepRight and ImproveOSM.

@BjornRasmussen
Copy link
Contributor

BjornRasmussen commented May 4, 2019

I think that this is be a good idea if it isn't on by default, similar to how keepright errors are not on by default. If a new user is editing, and suddenly starts seeing a bunch of yellow warnings on the map, they will likely not know what they mean and why they are there. Turning on the map symbols should be a checkbox in the validations pane with default not toggled.

@quincylvania
Copy link
Collaborator Author

I think that this is be a good idea if it isn't on by default

Yep, this would be optional.

I'm also thinking that feature highlighting similar to iD's visual diffs (#6843) might be better than badges. There's lots of potential for different highlight styles. Re: #6616.

@quincylvania quincylvania changed the title Show warning and error badges on the map Show warning and error statuses on the map Jan 7, 2020
@quincylvania quincylvania changed the title Show warning and error statuses on the map Show validation warnings and errors on the map Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

2 participants