Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative map styles #6616

Open
quincylvania opened this issue Jul 3, 2019 · 11 comments
Open

Alternative map styles #6616

quincylvania opened this issue Jul 3, 2019 · 11 comments
Labels
map-renderer An issue with how things are rendered in the map new-feature A new feature for iD

Comments

@quincylvania
Copy link
Collaborator

The default map styling is fine for most users most of the time, but there are times when domain-specific styling could be useful. For example:

We should build a general-purpose "lens" system that lets people quickly toggle between these styles ("lenses"). As part of #6483, lenses should be defined atomically and could be swapped in and out by downstream projects. Only some lenses would be suitable to ship with iD to everyone on osm.org, but ideally users could plug in their own lenses too.

I assume JOSM already has a feature like this. We should see how they do it.

@quincylvania
Copy link
Collaborator Author

The toolbar might not be the best place for these to live, but for inspiration:

Screen Shot 2019-07-03 at 4 31 54 PM

Screen Shot 2019-07-03 at 4 40 58 PM

@quincylvania quincylvania added the map-renderer An issue with how things are rendered in the map label Jul 3, 2019
@matkoniecz
Copy link
Contributor

I assume JOSM already has a feature like this. We should see how they do it.

It is called map paint styles in JOSM. See doc at https://josm.openstreetmap.de/wiki/Styles

https://josm.openstreetmap.de/raw-attachment/wiki/Styles/addstyle.gif

@quincylvania
Copy link
Collaborator Author

Looks like JSOM uses MapCSS. I wonder if iD should try to use that.

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 8, 2019

Not sure how hard is to implement it, but making possible to use all styles made for JOSM sounds very nice.

@sun-geo
Copy link
Contributor

sun-geo commented Jul 16, 2019

.... For example:

Sounds interesting, please add for me in the list

  • Road destination
  • Road lanes
  • Road turn:lanes

@1ec5
Copy link
Collaborator

1ec5 commented Jul 19, 2019

Many of the layers provided by the former ito! Map tool would be useful as lenses.

@don-vip
Copy link

don-vip commented Jul 20, 2019

@quincylvania see https://josm.openstreetmap.de/wiki/Help/Styles/MapCSSImplementation for the JOSM documentation. We use it both for styling and for validator rules.

@quincylvania quincylvania changed the title "Lens" system for alternative map styling Alternative map styles Aug 11, 2019
@mvexel
Copy link
Contributor

mvexel commented Aug 11, 2019

I like how you can overlay multiple styles in JOSM -- they're additive. While this can get messy and produce unpredictable results, it does allow for more detailed tweaking. Not sure if this is something we'd want for iD, though.

@quincylvania
Copy link
Collaborator Author

I like how you can overlay multiple styles in JOSM -- they're additive. While this can get messy and produce unpredictable results, it does allow for more detailed tweaking. Not sure if this is something we'd want for iD, though.

While I can see how this might be useful sometimes, I'm not sure the added complexity is worth it. "Messy and unpredictable" goes against iD's goals. Perhaps there's an elegant way we could allow multiple complementary styles in the future, but I think one-at-a-time is sufficient as an initial implementation.

@quincylvania quincylvania added the new-feature A new feature for iD label Aug 12, 2019
@1ec5
Copy link
Collaborator

1ec5 commented Aug 19, 2019

Unreviewed imports

Potlatch 2 has a “Highlight unedited TIGER (US roads)” option that still comes in handy in some parts of the U.S. Lenses like TIGER could be limited to certain regions (similar to imagery layers) or shareable somehow.

@quincylvania
Copy link
Collaborator Author

Since the change highlighting in #6843 came out pretty well, I'm thinking we might use the same outline mechanism for these other styles. The benefit is that we wouldn't lose the type information conveyed in the base rendering.

I'm inclined to forge ahead with a quick solution and not worry about MapCSS right now.

We'll also need a legend component somewhere to explain what the colors mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map new-feature A new feature for iD
Projects
None yet
Development

No branches or pull requests

6 participants